From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, gprocida@google.com,
kernel-team@android.com
Subject: Re: [PATCH 1/3] Improve and stabilise sort of member functions
Date: Mon, 02 Nov 2020 16:34:30 +0100 [thread overview]
Message-ID: <86eelbu60p.fsf@seketeli.org> (raw)
In-Reply-To: <20201029122100.765143-1-maennich@google.com> (Matthias Maennich's message of "Thu, 29 Oct 2020 12:20:58 +0000")
Matthias Maennich <maennich@google.com> a écrit:
> From: Giuliano Procida <gprocida@google.com>
>
> The functor virtual_member_function_less_than did not take into
> account linkage name which can be the only difference when multiple
> destructors with differing mangled names are present.
>
> This change adds a check for linkage names and also flattens the
> control flow in the comparison method to make the logic clearer.
>
> Lastly, this change also uses std::stable_sort, in case all that
> remains is insertion order.
>
> * src/abg-ir.cc
> (virtual_member_function_less_than::operator()): Name
> temporaries like offsets and symbols to reduce repetition;
> test each pair of elements (including symbol presence) and
> return immediately if there's a difference; add a comparison
> of linkage name just after comparing symbol names.
> (sort_virtual_member_functions): Use stable_sort instead of
> sort.
> * tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi:
> Update with new ordering of member functions.
> * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
> Likewise.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>
Applied to master.
Thanks!
--
Dodji
prev parent reply other threads:[~2020-11-02 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 12:20 Matthias Maennich
2020-10-29 12:20 ` [PATCH 2/3] Improve enum synthetic type names Matthias Maennich
2020-11-02 16:46 ` Dodji Seketeli
2020-10-29 12:21 ` [PATCH 3/3] dwarf-reader: Ignore zero length location expressions from DW_AT_location Matthias Maennich
2020-10-29 12:30 ` Matthias Maennich
2020-10-29 14:00 ` Mark Wielaard
2020-10-29 14:29 ` Matthias Maennich
2020-11-02 17:08 ` Dodji Seketeli
2020-11-02 16:48 ` Dodji Seketeli
2020-11-02 15:34 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86eelbu60p.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).