From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH 3/3] Add abidiff --offset-changes-are-harmless tests.
Date: Wed, 13 May 2020 13:48:00 +0200 [thread overview]
Message-ID: <86eerocaz3.fsf@seketeli.org> (raw)
In-Reply-To: <20200504162439.74028-4-gprocida@google.com> (Giuliano Procida's message of "Mon, 4 May 2020 17:24:39 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
> The new --offset-changes-are-harmless option changes the default
> interpretation of what constitutes a harmless change and impacts the
> --harmless and --no-harmful options.
>
> This commit adds tests covering the various possibilities.
>
> The object files have the following changes.
>
> - S::z changes from void* to int* (harmless)
> - S::a changes size (harmful)
> - S::b changes offset (normally harmful, harmless with new flag)
This patch depends on the resolution of the concern I have raised at
https://sourceware.org/pipermail/libabigail/2020q2/002229.html.
Cheers,
--
Dodji
next prev parent reply other threads:[~2020-05-13 11:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 16:24 [PATCH 0/3] Add an option to give finer-grained control of offset reporting Giuliano Procida
2020-05-04 16:24 ` [PATCH 1/3] abidiff.cc: tidy using directives and declarations Giuliano Procida
2020-05-13 11:27 ` Dodji Seketeli
2020-05-13 15:56 ` Giuliano Procida
2020-05-14 8:22 ` Dodji Seketeli
2020-05-04 16:24 ` [PATCH 2/3] Allow offset changes to be considered harmless Giuliano Procida
2020-05-13 11:46 ` Dodji Seketeli
2020-05-14 13:21 ` Giuliano Procida
2020-05-04 16:24 ` [PATCH 3/3] Add abidiff --offset-changes-are-harmless tests Giuliano Procida
2020-05-13 11:48 ` Dodji Seketeli [this message]
2020-05-12 14:51 ` [PATCH 0/3] Add an option to give finer-grained control of offset reporting Matthias Maennich
2020-05-13 12:06 ` Dodji Seketeli
2020-05-13 19:38 ` Matthias Maennich
2020-05-14 8:35 ` Dodji Seketeli
2020-05-14 12:39 ` Giuliano Procida
2020-05-18 20:16 ` Matthias Maennich
2020-05-20 7:57 ` Dodji Seketeli
2020-05-18 20:09 ` Matthias Maennich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86eerocaz3.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).