From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by sourceware.org (Postfix) with ESMTPS id EBAAB395C011 for ; Thu, 11 Jun 2020 10:06:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EBAAB395C011 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodj@seketeli.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 688476000C; Thu, 11 Jun 2020 10:06:58 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 57F611A07B9; Thu, 11 Jun 2020 12:06:57 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH] Fix HARMLESS_SYMBOL_ALIAS_CHANGE_CATEGORY spelling Organization: Me, myself and I References: <20200605114754.129211-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.8 X-URL: http://www.seketeli.net/~dodji Date: Thu, 11 Jun 2020 12:06:57 +0200 In-Reply-To: <20200605114754.129211-1-gprocida@google.com> (Giuliano Procida's message of "Fri, 5 Jun 2020 12:47:54 +0100") Message-ID: <86ftb1hq66.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_STOCKGEN, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 10:07:01 -0000 Hello, Giuliano Procida a =C3=A9crit: > The enumerator HARMLESS_SYMBOL_ALIAS_CHANGE_CATEORY has a spelling > mistake in it. This changes fixes this and also corrects the spelling > of both this and HARMLESS_UNION_CHANGE_CATEORY when output. > > * include/abg-comparison.h (enum diff_category): Rename > HARMLESS_SYMBOL_ALIAS_CHANGE_CATEORY enumerator to > HARMLESS_SYMBOL_ALIAS_CHANGE_CATEGORY. > * src/abg-comp-filter.cc (categorize_harmless_diff_node): Replace > use of HARMLESS_SYMBOL_ALIAS_CHANGE_CATEORY enumerator with > HARMLESS_SYMBOL_ALIAS_CHANGE_CATEGORY. > * src/abg-comparison.cc (get_default_harmless_categories_bitmap): > Replace use of HARMLESS_SYMBOL_ALIAS_CHANGE_CATEORY enumerator > with HARMLESS_SYMBOL_ALIAS_CHANGE_CATEGORY. > (operator<<): In the diff_category overload, replace use of > HARMLESS_SYMBOL_ALIAS_CHANGE_CATEORY enumerator with > HARMLESS_SYMBOL_ALIAS_CHANGE_CATEGORY and output correct > spelling for both this and HARMLESS_UNION_CHANGE_CATEGORY. > * tools/abicompat.cc (create_diff_context): Replace use of > HARMLESS_SYMBOL_ALIAS_CHANGE_CATEORY enumerator with > HARMLESS_SYMBOL_ALIAS_CHANGE_CATEGORY. > > Signed-off-by: Giuliano Procida Acked-by: Dodji Seketeli Applied to master, thanks! Cheers, --=20 Dodji