From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by sourceware.org (Postfix) with ESMTPS id DC21D384B824; Mon, 8 Feb 2021 13:14:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DC21D384B824 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodj@seketeli.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B41CB1C0008; Mon, 8 Feb 2021 13:14:31 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id A25CA1A06CE; Mon, 8 Feb 2021 14:14:30 +0100 (CET) From: Dodji Seketeli To: gprocida+abigail at google dot com Cc: libabigail@sourceware.org Subject: Re: [Bug default/26012] abidiff: do not emit qualified name for data members Organization: Me, myself and I References: X-Operating-System: Red Hat Enterprise Linux Server 7.8 X-URL: http://www.seketeli.net/~dodji Date: Mon, 08 Feb 2021 14:14:30 +0100 In-Reply-To: (gprocida's message of "Tue, 26 Jan 2021 13:14:23 +0000") Message-ID: <86h7mmhfbd.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 13:14:39 -0000 Hello, gprocida+abigail at google dot com via Libabigail a =C3=A9crit: > https://sourceware.org/bugzilla/show_bug.cgi?id=3D26012 > > Giuliano Procida changed: > > What |Removed |Added > -------------------------------------------------------------------------= --- > CC| |gprocida+abigail at goog= le dot com > > --- Comment #1 from Giuliano Procida = --- > Dodji, how would you feel about an intermediate stage where the types are > retained, but the redundant qualification is eliminated? I like the idea! > 'struct task_struct at sched.h:635:1' changed: > type size hasn't changed > 1 data member insertion: > 'unsigned int in_ubsan', at offset 16704 (in bits) at sched.h:1006:1 > there are data member changes: > 'void* journal_info' offset changed from 16704 to 16768 (in bits) (by= +64 > bits) > 'bio_list* bio_list' offset changed from 16768 to 16832 (in bits) (by= +64 > bits) > 'blk_plug* plug' offset changed from 16832 to 16896 (in bits) (by +64= bits) > 'reclaim_state* reclaim_state' offset changed from 16896 to 16960 (in= bits) > (by +64 bits) > 'backing_dev_info* backing_dev_info' offset changed from 16960 to 170= 24 (in > bits) (by +64 bits) > 'io_context* io_context' offset changed from 17024 to 17088 (in bits)= (by > +64 bits) > 'capture_control* capture_control' offset changed from 17088 to 17152= (in > bits) (by +64 bits) > 'unsigned long int ptrace_message' offset changed from 17152 to 17216= (in > bits) (by +64 bits) > 'kernel_siginfo_t* last_siginfo' offset changed from 17216 to 17280 (= in > bits) (by +64 bits) And I like the output as well. I think it's perfect. Thanks. Cheers, --=20 Dodji