* Re: [PATCH] Sort kernel module object files before processing them.
2020-01-01 0:00 [PATCH] Sort kernel module object files before processing them Giuliano Procida via libabigail
2020-01-01 0:00 ` Dodji Seketeli
@ 2020-01-01 0:00 ` Matthias Maennich via libabigail
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Maennich via libabigail @ 2020-01-01 0:00 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, dodji, kernel-team, Jessica Yu
Hi Giuliano!
On Tue, Feb 04, 2020 at 05:16:27PM +0000, Android Kernel Team wrote:
>This imposes a deterministic ordering, making diffs more predictable
>and allowing reproducible testing.
>
> * src/abg-tools-utils.cc (get_binary_paths_from_kernel_dist):
> Sort module_paths.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>
>---
> src/abg-tools-utils.cc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/src/abg-tools-utils.cc b/src/abg-tools-utils.cc
>index 6608ffd5..92a27d08 100644
>--- a/src/abg-tools-utils.cc
>+++ b/src/abg-tools-utils.cc
>@@ -2326,7 +2326,8 @@ find_vmlinux_path(const string& from,
> /// binary that was found.
> ///
> /// @param module_paths output parameter. The paths of the kernel
>-/// module binaries that were found.
>+/// module binaries that were found, sorted to impose a deterministic
>+/// ordering.
> ///
> /// @return true if at least the path to the vmlinux binary was found.
> bool
>@@ -2365,6 +2366,8 @@ get_binary_paths_from_kernel_dist(const string& dist_root,
> if (find_vmlinux_and_module_paths(from, vmlinux_path, module_paths))
> found = true;
>
>+ std::sort(module_paths.begin(), module_paths.end());
>+
That is a much less invasive change than my previously suggested (but
for some reason a bit flawed) approach [1]. Thanks!
Reviewed-by: Matthias Maennich <maennich@google.com>
Cheers,
Matthias
[1] https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=d445c72b2b1983f6540d8a74fa8b74e47f2b581c
> return found;
> }
>
>--
>2.25.0.341.g760bfbb309-goog
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Sort kernel module object files before processing them.
@ 2020-01-01 0:00 Giuliano Procida via libabigail
2020-01-01 0:00 ` Dodji Seketeli
2020-01-01 0:00 ` Matthias Maennich via libabigail
0 siblings, 2 replies; 3+ messages in thread
From: Giuliano Procida via libabigail @ 2020-01-01 0:00 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida
This imposes a deterministic ordering, making diffs more predictable
and allowing reproducible testing.
* src/abg-tools-utils.cc (get_binary_paths_from_kernel_dist):
Sort module_paths.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-tools-utils.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/abg-tools-utils.cc b/src/abg-tools-utils.cc
index 6608ffd5..92a27d08 100644
--- a/src/abg-tools-utils.cc
+++ b/src/abg-tools-utils.cc
@@ -2326,7 +2326,8 @@ find_vmlinux_path(const string& from,
/// binary that was found.
///
/// @param module_paths output parameter. The paths of the kernel
-/// module binaries that were found.
+/// module binaries that were found, sorted to impose a deterministic
+/// ordering.
///
/// @return true if at least the path to the vmlinux binary was found.
bool
@@ -2365,6 +2366,8 @@ get_binary_paths_from_kernel_dist(const string& dist_root,
if (find_vmlinux_and_module_paths(from, vmlinux_path, module_paths))
found = true;
+ std::sort(module_paths.begin(), module_paths.end());
+
return found;
}
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Sort kernel module object files before processing them.
2020-01-01 0:00 [PATCH] Sort kernel module object files before processing them Giuliano Procida via libabigail
@ 2020-01-01 0:00 ` Dodji Seketeli
2020-01-01 0:00 ` Matthias Maennich via libabigail
1 sibling, 0 replies; 3+ messages in thread
From: Dodji Seketeli @ 2020-01-01 0:00 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, kernel-team
Hello Giuliano,
Giuliano Procida <gprocida@google.com> a écrit:
> This imposes a deterministic ordering, making diffs more predictable
> and allowing reproducible testing.
>
> * src/abg-tools-utils.cc (get_binary_paths_from_kernel_dist):
> Sort module_paths.
This looks goods to me and I have applied it to master.
Thanks!
--
Dodji
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-19 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-01 0:00 [PATCH] Sort kernel module object files before processing them Giuliano Procida via libabigail
2020-01-01 0:00 ` Dodji Seketeli
2020-01-01 0:00 ` Matthias Maennich via libabigail
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).