From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3089 invoked by alias); 20 Nov 2015 15:36:16 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 3078 invoked by uid 89); 20 Nov 2015 15:36:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.98.7 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,URIBL_BLACK autolearn=no version=3.3.2 X-Spam-Status: No, score=1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,URIBL_BLACK autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: * X-HELO: ms.seketeli.fr From: Dodji Seketeli To: Ondrej Oprala Cc: libabigail@sourceware.org Subject: Re: [PATCH] #19240 - completion scripts Organization: Me, myself and I References: <5649AD86.5090707@redhat.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.2 Beta X-URL: http://www.seketeli.net/~dodji Date: Thu, 01 Jan 2015 00:00:00 -0000 In-Reply-To: <5649AD86.5090707@redhat.com> (Ondrej Oprala's message of "Mon, 16 Nov 2015 11:18:46 +0100") Message-ID: <86io4wvg2d.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-q4/txt/msg00180.txt.bz2 Hello Ondrej, Ondrej Oprala a =C3=A9crit: > Hey, I've whipped up a set of scripts for the abigail tools. > It should be complete. Great! This is really cool. > However, when an elf-file is expected, > all regular files are completed for now. Quite frankly, I am not concerned by this :-) > Distcheck passes. Cool. I just have one minor nit: > --- a/Makefile.am > +++ b/Makefile.am [...] > +include bash-completion/Makemodule.am I think I understand the benefits of using a scheme of non-recursive makefiles. But right now, the project does use recursive makefile all over the place. If we were to use non-recursive makefiles, then I'd be for doing it properly for the entire project, not just for one sub-directory like in the change above. So for now, I'd prefer that we just append the new bash-complete directory name to the content SUBDIRS variable on the firstline of this Makefile.am, and add a Makefile.am file in that directory, rather than a Makemodule.am file. The configure.ac file will also have to be updated accordingly. OK to commit with that change, thanks! Cheers, [...] --=20 Dodji