From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by sourceware.org (Postfix) with ESMTPS id 1FA10385481C for ; Thu, 11 Mar 2021 09:11:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1FA10385481C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodj@seketeli.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id ADC9A1C000E; Thu, 11 Mar 2021 09:11:31 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id E25381A1009; Thu, 11 Mar 2021 10:11:30 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, mark@klomp.org Subject: Re: [PATCH] DWARF reader: Comment ARM32 ELF address interpretation Organization: Me, myself and I References: <20210310122254.2860952-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.9 X-URL: http://www.seketeli.net/~dodji Date: Thu, 11 Mar 2021 10:11:30 +0100 In-Reply-To: <20210310122254.2860952-1-gprocida@google.com> (Giuliano Procida's message of "Wed, 10 Mar 2021 12:22:54 +0000") Message-ID: <86k0qejbr1.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 09:11:35 -0000 Giuliano Procida a =C3=A9crit: > Bug 27552 - libabigail needs to interpret ARM32 symbol addresses specially > > The previous commit omitted any code commentary. This adds a link to > the relevant reference. The code is shortened slightly as well. > > * src/abg-dwarf-reader.cc > (read_context::load_symbol_maps_from_symtab_section): Add > descriptive comment to ARM32 address handling; shorten > the assignment using &=3D. > > Signed-off-by: Giuliano Procida Applied to master, thanks. Cheers, --=20 Dodji