From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by sourceware.org (Postfix) with ESMTPS id 586C8395C424 for ; Wed, 24 Jun 2020 05:40:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 586C8395C424 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodj@seketeli.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 97A47200004; Wed, 24 Jun 2020 05:40:04 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 46EE21A0F37; Wed, 24 Jun 2020 07:40:03 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH] get_canonical_type_for: restore environment better Organization: Me, myself and I References: <20200617161720.37446-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.8 X-URL: http://www.seketeli.net/~dodji Date: Wed, 24 Jun 2020 07:40:03 +0200 In-Reply-To: <20200617161720.37446-1-gprocida@google.com> (Giuliano Procida's message of "Wed, 17 Jun 2020 17:17:20 +0100") Message-ID: <86k0zxxbrg.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2020 05:40:07 -0000 Giuliano Procida a =C3=A9crit: > The method type_base::get_canonical_type_for contains some logic which > temporarily changes a couple of control flags in the type's > environment. It then restores these, but not consistently. > > This patch ensures the flags are restored unconditionally. > > * src/abg-ir.cc (get_canonical_type_for): Ensure the > do_on_the_fly_canonicalization and > decl_only_class_equals_definition flags are restored > unconditionally. > > Signed-off-by: Giuliano Procida Applied to master, thanks!=20 Cheers, --=20 Dodji