From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, gprocida@google.com,
kernel-team@android.com
Subject: Re: [PATCH 2/2] dwarf-reader: read_context: drop unused symbol versioning code
Date: Wed, 10 Jun 2020 18:02:26 +0200 [thread overview]
Message-ID: <86k10ehpt9.fsf@seketeli.org> (raw)
In-Reply-To: <20200518114536.202504-2-maennich@google.com> (Matthias Maennich's message of "Mon, 18 May 2020 13:45:36 +0200")
Matthias Maennich <maennich@google.com> a écrit:
> Since the symbol versioning helper code has been moved to elf_helpers in
> commit 9815efe7a5be ("abg-elf-helpers: move some versioning helpers
> from abg-dwarf-reader"), remove the leftover unused code from
> read_context.
>
> * src/abg-dwarf-reader.cc
> (read_context::versym_section_): Delete.
> (read_context::verdef_section_): Delete.
> (read_context::verneed_section_): Delete.
> (read_context::symbol_versionning_sections_loaded_): Delete.
> (read_context::symbol_versionning_sections_found_): Delete.
> (read_context::initialize): Remove initializations of deleted members.
> (read_context::get_symbol_versionning_sections): Delete.
> (read_context::get_version_for_symbol): Delete.
> (read_context::lookup_elf_symbol_from_index): Use
> get_version_for_symbol provided by elf_helpers.
>
> Signed-off-by: Matthias Maennich <maennich@google.com>
Acked-by: Dodji Seketeli <dodji@redhat.com>
Applied to master, thanks!
Cheers,
--
Dodji
next prev parent reply other threads:[~2020-06-10 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 11:45 [PATCH 1/2] dwarf-reader: Remove unused code Matthias Maennich
2020-05-18 11:45 ` [PATCH 2/2] dwarf-reader: read_context: drop unused symbol versioning code Matthias Maennich
2020-06-10 16:02 ` Dodji Seketeli [this message]
2020-06-10 16:01 ` [PATCH 1/2] dwarf-reader: Remove unused code Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k10ehpt9.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).