From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH] [abisym] Remove leading space in output.
Date: Wed, 11 Mar 2020 09:18:26 +0100 [thread overview]
Message-ID: <86k13ruwx9.fsf@seketeli.org> (raw)
In-Reply-To: <20200310103113.54010-1-gprocida@google.com> (Giuliano Procida's message of "Tue, 10 Mar 2020 10:31:13 +0000")
Hello Giuliano,
Giuliano Procida <gprocida@google.com> a écrit:
> When abisym reports a symbol as found, it currently emits a leading
> space. It does not do this when reporting a symbol as not found.
>
> This patch removes the leading space.
>
> * tools/abisym.cc (main): Remove leading space from output.
> * tests/data/test-lookup-syms/test0-report.txt: Remove leading
> space from expected output.
> * tests/data/test-lookup-syms/test01-report.txt: Ditto.
> * tests/data/test-lookup-syms/test02-report.txt: Ditto.
> * tests/data/test-lookup-syms/test1-1-report.txt: Ditto.
This looks good to me and I have applied it to master.
I have just edited the short line of the commit log to prefix it with
"abysym:".
Thanks!
Cheers,
--
Dodji
prev parent reply other threads:[~2020-03-11 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 10:31 Giuliano Procida
2020-03-10 12:50 ` Matthias Maennich
2020-03-11 8:18 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k13ruwx9.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).