From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40993 invoked by alias); 6 Mar 2020 14:32:14 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 40983 invoked by uid 89); 6 Mar 2020 14:32:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: relay1-d.mail.gandi.net Received: from relay1-d.mail.gandi.net (HELO relay1-d.mail.gandi.net) (217.70.183.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Mar 2020 14:32:12 +0000 X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodj@seketeli.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 530DE240019; Fri, 6 Mar 2020 14:32:09 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 269061A0F55; Fri, 6 Mar 2020 15:32:08 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 1/2] Add space missing between "[C]" tag and description of changed item. Organization: Me, myself and I References: <20200305160317.101386-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.7 X-URL: http://www.seketeli.net/~dodji Date: Wed, 01 Jan 2020 00:00:00 -0000 In-Reply-To: <20200305160317.101386-1-gprocida@google.com> (Giuliano Procida's message of "Thu, 5 Mar 2020 16:03:16 +0000") Message-ID: <86k13xwo47.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-q1/txt/msg00112.txt Hello Giuliano, Giuliano Procida a =C3=A9crit: > All such tags are now followed by a space and are more readable. > > * src/abg-default-reporter.cc (report(corpus_diff)): Output > space after "[C]". > * src/abg-leaf-reporter.cc (report(corpus_diff)): Output space > after "[C]" > * tests/data/test-*/*report*.txt: Update all the test > reports. This looks goods to me so I have pushed it to master. I have just edited the ChangeLog part of the commit log message to make it comply wih the existing ChangeLog entries. It now looks like: ------------------------>8<------------------------- Add space missing between "[C]" tag and description of changed item. All such tags are now followed by a space and are more readable. * src/abg-default-reporter.cc (report): In the overload for corpus_diff, output space after "[C]". * src/abg-leaf-reporter.cc (report): Likewise. * tests/data/test-*/*report*.txt: Update all the test reports. ------------------------>8<------------------------- Thanks!! Cheers, --=20 Dodji