From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id 1EDB3389246C for ; Tue, 12 Jan 2021 10:08:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1EDB3389246C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.65 Received: from localhost (91-166-131-65.subs.proxad.net [91.166.131.65]) (Authenticated sender: dodj@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 0E363FF813; Tue, 12 Jan 2021 10:08:44 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 08F0A1A0F99; Tue, 12 Jan 2021 11:08:44 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com, Chris Kennelly Subject: Re: [PATCH] abg-ir: Optimize calls to std::string::find() for a single char. Organization: Me, myself and I References: <20201215214519.2992965-1-maennich@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.8 X-URL: http://www.seketeli.net/~dodji Date: Tue, 12 Jan 2021 11:08:44 +0100 In-Reply-To: <20201215214519.2992965-1-maennich@google.com> (Matthias Maennich's message of "Tue, 15 Dec 2020 21:45:19 +0000") Message-ID: <86mtxejwlv.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, FROM_FMBLA_NEWDOM28, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 10:08:48 -0000 Matthias Maennich a =C3=A9crit: > This is a common micro optimization suggested by clang-tidy to improve > string::find performance. I have not done any measurements as to how it > impacts performance for that particular piece of code, but generally > this overload is to prefer here. > > * src/abg-ir.cc (elf_symbol::get_name_and_version_from_id): > use character literal overload for single character string::find. > (parse_integral_type): Likewise. > > Suggested-by: Chris Kennelly > Signed-off-by: Matthias Maennich Applied to master, thanks! Cheers, --=20 Dodji