From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by sourceware.org (Postfix) with ESMTPS id 717A93836C62 for ; Tue, 9 Mar 2021 18:03:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 717A93836C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodj@seketeli.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 2CAEB200008; Tue, 9 Mar 2021 18:03:27 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 1B5991A101B; Tue, 9 Mar 2021 19:03:27 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 03/20] abg-ir: elf_symbol: add is_suppressed field Organization: Me, myself and I References: <20200619214305.562-1-maennich@google.com> <20210127125853.886677-1-maennich@google.com> <20210127125853.886677-4-maennich@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.9 X-URL: http://www.seketeli.net/~dodji Date: Tue, 09 Mar 2021 19:03:27 +0100 In-Reply-To: <20210127125853.886677-4-maennich@google.com> (Matthias Maennich's message of "Wed, 27 Jan 2021 12:58:36 +0000") Message-ID: <86o8fsjjbk.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2021 18:03:32 -0000 Matthias Maennich a =C3=A9crit: > In the context of libabigail and a single library run (when reading from > dwarf or from xml), a symbol is either suppressed or it is not. While > one could argue that this is a property of the read_context, the > read_context might not be around anymore when the symbol still is. > Hence, persist the 'is_suppressed' state along with the symbol itself. In the future, if needed be, maybe well rather make the "applied" suppressi= on specifications be part of the ABI corpus they are related to. That way, the is_suppressed becomes a function, rather than a static property, similarly to what is done for abigail::comparison::diff::is_suppressed(). This could be useful for usecases where we'd want to apply a new suppression specification to the IR on the fly and see the impact. I guess when we have that usecase, then we'll change this. I just thought I'd share this :-) [...] > +bool > +elf_symbol::is_suppressed() const > +{return priv_->is_suppressed_;} > + > +void > +elf_symbol::set_is_suppressed(bool is_suppressed) > +{priv_->is_suppressed_ =3D is_suppressed;} > + I have added doxygen comments to these two accessors. [...] > Reviewed-by: Giuliano Procida > Signed-off-by: Matthias Maennich Applied to master. Thanks! --=20 Dodji