From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 814 invoked by alias); 6 Mar 2020 13:50:04 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 798 invoked by uid 89); 6 Mar 2020 13:50:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=comply, god X-Spam-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: relay6-d.mail.gandi.net Received: from relay6-d.mail.gandi.net (HELO relay6-d.mail.gandi.net) (217.70.183.198) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Mar 2020 13:50:01 +0000 X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodj@seketeli.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C636CC000A; Fri, 6 Mar 2020 13:49:57 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 98A001A0778; Fri, 6 Mar 2020 14:49:56 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH] Correct various inconsequential typos. Organization: Me, myself and I References: <20200305153431.86434-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.7 X-URL: http://www.seketeli.net/~dodji Date: Wed, 01 Jan 2020 00:00:00 -0000 In-Reply-To: <20200305153431.86434-1-gprocida@google.com> (Giuliano Procida's message of "Thu, 5 Mar 2020 15:34:31 +0000") Message-ID: <86o8t9wq2j.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-q1/txt/msg00111.txt Hey Giuliano, Giuliano Procida a =C3=A9crit: > In the leaf reporter member subtype changes are labelled as plain > changes and vice versa. This was probably due to the different > ordering of the code sections in the default and leaf reporters. > Output is unchanged as these tags currently map to the same strings. > > When generating diff reports there were some rare cases where a > pretty representation might have been emitted twice or the trailing > whitespace might have been missing. > > * src/abg-leaf-reporter.cc: report(class_or_union_diff) Swap > calls to report_mem_header to match the rest of the code. > * src/abg-reporter-priv.cc: represent(var_diff_sptr) Add some > missing whitespace; remember we've emitted the pretty > representation in 2 cases where this was omitted (though 1 of > these is the last case where it makes no difference). > maybe_report_diff_for_symbol Add some missing whitespace; > remember we've reported a diff (and need a trailing newline) > in 1 case where this was omitted, also affecting the > return value of the function (but no caller cares). This looks god to me, so I have pushed it to master. I have just edited the to make it comply wih the ChangeLog editing rules. It now looks like: ------------------>8<---------------------- Correct various inconsequential typos. In the leaf reporter member subtype changes are labelled as plain changes and vice versa. This was probably due to the different ordering of the code sections in the default and leaf reporters. Output is unchanged as these tags currently map to the same strings. When generating diff reports there were some rare cases where a pretty representation might have been emitted twice or the trailing whitespace might have been missing. * src/abg-leaf-reporter.cc (report): In the class_or_union_diff overoad, swap calls to report_mem_header to match the rest of the code. * src/abg-reporter-priv.cc (represent): In the var_diff_sptr overload, add some missing whitespace; remember we've emitted the pretty representation in 2 cases where this was omitted (though 1 of these is the last case where it makes no difference). maybe_report_diff_for_symbol Add some missing whitespace; remember we've reported a diff (and need a trailing newline) in 1 case where this was omitted, also affecting the return value of the function (but no caller cares). ------------------>8<---------------------- Thanks! Cheers, --=20 Dodji