* Re: [PATCH] Fix -Wmisleading-indentation warning in abg-leaf-reporter.cc.
2017-01-01 0:00 [PATCH] Fix -Wmisleading-indentation warning in abg-leaf-reporter.cc Mark Wielaard
@ 2017-01-01 0:00 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2017-01-01 0:00 UTC (permalink / raw)
To: Mark Wielaard; +Cc: libabigail
Hello,
Mark Wielaard <mark@klomp.org> a écrit:
[...]
> * src/abg-leaf-reporter.cc (leaf_reporter::report): Fix misleading
> indentation.
I have just pushed this to master.
Thanks!
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] Fix -Wmisleading-indentation warning in abg-leaf-reporter.cc.
@ 2017-01-01 0:00 Mark Wielaard
2017-01-01 0:00 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2017-01-01 0:00 UTC (permalink / raw)
To: libabigail; +Cc: Mark Wielaard
abg-leaf-reporter.cc: In member function âvirtual void abigail::comparison::leaf_reporter::report(const abigail::comparison::qualified_type_diff&, std::ostream&, const string&) constâ:
abg-leaf-reporter.cc:158:3: warning: this âifâ clause does not guard... [-Wmisleading-indentation]
if (!diff_to_be_reported(&d))
^~
abg-leaf-reporter.cc:161:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the âifâ
report_local_qualified_type_changes(d, out, indent);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* src/abg-leaf-reporter.cc (leaf_reporter::report): Fix misleading
indentation.
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
src/abg-leaf-reporter.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/abg-leaf-reporter.cc b/src/abg-leaf-reporter.cc
index f68f17c..6fe4b19 100644
--- a/src/abg-leaf-reporter.cc
+++ b/src/abg-leaf-reporter.cc
@@ -158,7 +158,7 @@ leaf_reporter::report(const qualified_type_diff& d, ostream& out,
if (!diff_to_be_reported(&d))
return;
- report_local_qualified_type_changes(d, out, indent);
+ report_local_qualified_type_changes(d, out, indent);
}
/// Report the changes carried by a @ref pointer_diff node.
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-09 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-01 0:00 [PATCH] Fix -Wmisleading-indentation warning in abg-leaf-reporter.cc Mark Wielaard
2017-01-01 0:00 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).