From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by sourceware.org (Postfix) with ESMTPS id 70A4E388F049 for ; Mon, 11 May 2020 13:24:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70A4E388F049 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodj@seketeli.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 591EBE000D; Mon, 11 May 2020 13:24:20 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id ED1141A07A6; Mon, 11 May 2020 15:24:18 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH v4 01/15] Tidy #includes in a few files. Organization: Me, myself and I References: <20200424092132.150547-1-gprocida@google.com> <20200504123416.243214-1-gprocida@google.com> <20200504123416.243214-2-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.7 X-URL: http://www.seketeli.net/~dodji Date: Mon, 11 May 2020 15:24:18 +0200 In-Reply-To: <20200504123416.243214-2-gprocida@google.com> (Giuliano Procida's message of "Mon, 4 May 2020 13:34:02 +0100") Message-ID: <86r1vqhaf1.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2020 13:24:23 -0000 Giuliano Procida a =C3=A9crit: > Following review of a recent change to move regex definitions into > their own files, this commit ensures that #include directives are > separated into categories and sorted alphabetically within the categories= ,=20 Just as a comment, I don't have a strong opinion about alphabetically sorting header files. I don't intend to require that for the project. I am not rejecting this change however. > subject to known ordering constraints (such as > "config.h" first, "abg-internal.h" before visibility directives etc.). These ordering constraints are however important to respect for obvious reasons. So these are the ones I am interested in :-) Thank you for doing this. > > There are no behavioural changes. > > * src/abg-corpus-priv.h: Separate and sort #include > directives. > * src/abg-corpus.cc: Ditto. > * src/abg-regex.cc: Ditto. > * src/abg-suppression-priv.h: Ditto. > * src/abg-suppression.cc: Ditto. Applied to master, thanks! Cheers, --=20 Dodji