From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by sourceware.org (Postfix) with ESMTPS id 10448382E83E for ; Tue, 9 Mar 2021 14:05:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 10448382E83E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodj@seketeli.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id EB3D91BF203; Tue, 9 Mar 2021 14:05:28 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 3C0B41A1026; Tue, 9 Mar 2021 15:05:28 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 02/20] abg-ir: elf_symbol: add is_in_ksymtab field Organization: Me, myself and I References: <20200619214305.562-1-maennich@google.com> <20210127125853.886677-1-maennich@google.com> <20210127125853.886677-3-maennich@google.com> X-Operating-System: Red Hat Enterprise Linux Server 7.9 X-URL: http://www.seketeli.net/~dodji Date: Tue, 09 Mar 2021 15:05:28 +0100 In-Reply-To: <20210127125853.886677-3-maennich@google.com> (Matthias Maennich's message of "Wed, 27 Jan 2021 12:58:35 +0000") Message-ID: <86sg54juc7.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2021 14:05:33 -0000 Hello, Matthias Maennich a =C3=A9crit: > Being exported through a ksymtab (in case of Linux Kernel binaries) is > actually a property of the Elf symbol itself and we can therefore track > it along with the symbol that we collect from symtab. While tracking is > currently done by keeping separate symbol lists and maps for symtab and > ksymtab symbols, they can be consolidated having a property to indicate > whether this symbol also appeared as a ksymtab entry. Just for some context, the reason why I kept that property out of the [ir] module is that in my mind, the abigail::ir::elf_symbol type was meant to be "independant" from whatever specificity a particular platform would have, regarding an ELF symbol. For instance, when looking at user space ELF symbol, "is_in_ksymtab" does not really make sense. I guess this "ideal" got destroyed by the addition of the "is_linux_string_cst" property to that type, and I think I mourned that ideal at this point. I think we can now say that the userspace and kernel use case are first citizen use cases and they just ought to be there :-) [...] > diff --git a/src/abg-ir.cc b/src/abg-ir.cc > index d1d02f3aad5d..22532cc87dfd 100644 > --- a/src/abg-ir.cc > +++ b/src/abg-ir.cc [...] > @@ -1686,6 +1703,14 @@ bool > elf_symbol::is_variable() const > {return get_type() =3D=3D OBJECT_TYPE || get_type() =3D=3D TLS_TYPE;} >=20=20 > +bool > +elf_symbol::is_in_ksymtab() const > +{return priv_->is_in_ksymtab_;} > + > +void > +elf_symbol::set_is_in_ksymtab(bool is_in_ksymtab) > +{priv_->is_in_ksymtab_ =3D is_in_ksymtab;} > + These two member function definitions lack doxygen comment. I took the liberty to add some there. [...] > Reviewed-by: Giuliano Procida > Signed-off-by: Matthias Maennich Applied to master with the changes above. [...] Thanks! --=20 Dodji