From: Dodji Seketeli <dodji@seketeli.org>
To: Mark Wielaard <mark@klomp.org>
Cc: Matthias Maennich <maennich@google.com>,
libabigail@sourceware.org, kernel-team@android.com,
gprocida@google.com
Subject: Re: [PATCH] configure: add ABIGAIL_DEBUG options
Date: Wed, 13 May 2020 13:01:50 +0200 [thread overview]
Message-ID: <86v9l0cd41.fsf@seketeli.org> (raw)
In-Reply-To: <9fc4154f56f1d593f33ae52297a028dc4c9faf06.camel@klomp.org> (Mark Wielaard's message of "Mon, 11 May 2020 19:04:34 +0200")
Hello,
Mark Wielaard <mark@klomp.org> a écrit:
[...]
> From a5b9bda8a44da06985fbd938b55e209c94893175 Mon Sep 17 00:00:00 2001
> From: Mark Wielaard <mark@klomp.org>
> Date: Mon, 11 May 2020 18:55:03 +0200
> Subject: [PATCH] Don't iterate before the start of a
> RandomAccessOutputIterator.
>
> Found with -D_GLIBCXX_DEBUG. You cannot go before the start of an
> RandomAccessOutputIterator. Iterator -1 + 1 might seem to work,
> but is actually undefined behaviour.
>
> * include/abg-diff-utils.h (compute_diff): Put brackets around
> p[ux].[xy]() + 1 calculation.
>
> Signed-off-by: Mark Wielaard <mark@klomp.org>
Acked-by: Dodji Seketeli <dodji@seketeli.org>
Applied to master, thanks!
--
Dodji
next prev parent reply other threads:[~2020-05-13 11:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 15:24 Matthias Maennich
2020-05-11 17:04 ` Mark Wielaard
2020-05-11 20:07 ` Matthias Maennich
2020-05-12 10:47 ` Giuliano Procida
2020-05-12 11:59 ` Mark Wielaard
2020-05-12 14:33 ` Matthias Maennich
2020-05-13 10:43 ` Dodji Seketeli
2020-05-13 20:25 ` Matthias Maennich
2020-05-14 8:19 ` Dodji Seketeli
2020-05-13 11:19 ` Dodji Seketeli
2020-05-13 20:12 ` Matthias Maennich
2020-05-27 20:52 ` Matthias Männich
2020-05-13 11:01 ` Dodji Seketeli [this message]
2020-05-11 17:24 ` Ben Woodard
2020-05-15 9:19 ` [PATCH v2] " Matthias Maennich
2020-05-18 7:38 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v9l0cd41.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).