From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 0C6CA393D024 for ; Tue, 1 Dec 2020 09:51:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0C6CA393D024 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-335-izTi2G0fO26edp5flRYhrA-1; Tue, 01 Dec 2020 04:51:27 -0500 X-MC-Unique: izTi2G0fO26edp5flRYhrA-1 Received: by mail-wr1-f69.google.com with SMTP id w17so786251wrl.8 for ; Tue, 01 Dec 2020 01:51:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=yjymzKWJxE3Ojj96rwmhmlP6C+1H3C7cs8HXmbjqCpg=; b=mdSpwUSJGyma9rS64nWZW2GTUXpB23DaWYkds+o05Af+FDI3Uiq7JwXL1Fyp8M1mo/ cu/U8a8qTDxCheWcdoNjDbWGWfVlKpE2jXgb/N53E3pIGGFQE50aZvobh4InBdSGJ0Ou zizggP1iQA8opPaXq0SNxmEFuBypb6foYjUGa8nTKI+7+pTHsE03rNx4lSqRcwVBElRG 5yON8YhPqOjDTjXo55KE4847FDC+7yiYTab2eB8iMNyuQ/LF2BT4tVXsMKoQEL6pbNOR /ic5hrLwi4qNVUS/alMVGJImxTNXoAWeTePzpe9ej43IgoJqV5JDo8tCNmNxIGTpVr7q 6XKg== X-Gm-Message-State: AOAM5300+PVKcqNZwksGEuKKBDNaNgBLZIFL9CW9Ss8kTDEFo6LE526k D4FN0KjOKAYfg7iGAJyrXZS0R+pfw3bEJkBPX/LAoFT3j4xcFTCDv/1l81Y7nPDCA6OQSSPBorR PhVWsowWxTz3kHwjx421w X-Received: by 2002:a1c:9a4d:: with SMTP id c74mr1892622wme.5.1606816285609; Tue, 01 Dec 2020 01:51:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJys/MKl0V3Z/6rlCp/kKjbC14aC0yELxh8Ha7kS7JqHZHQ++X8pCnQvtfmFxB7Qx7kOZsT1Jw== X-Received: by 2002:a1c:9a4d:: with SMTP id c74mr1892607wme.5.1606816285334; Tue, 01 Dec 2020 01:51:25 -0800 (PST) Received: from localhost (91-166-131-65.subs.proxad.net. [91.166.131.65]) by smtp.gmail.com with ESMTPSA id w21sm1881819wmi.29.2020.12.01.01.51.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Dec 2020 01:51:24 -0800 (PST) Received: by localhost (Postfix, from userid 1001) id D816F1A2628; Tue, 1 Dec 2020 10:51:22 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: Giuliano Procida via Libabigail Subject: Re: [PATCH 1/6] writer: Emit definitions of declarations when they are present Organization: Red Hat / France References: <87h7pa7n8c.fsf@redhat.com> <87czzy7mw5.fsf@redhat.com> <87a6uy6dp9.fsf@seketeli.org> X-Operating-System: Red Hat Enterprise Linux Server 7.8 X-URL: http://www.redhat.com Date: Tue, 01 Dec 2020 10:51:22 +0100 In-Reply-To: (Giuliano Procida's message of "Mon, 30 Nov 2020 18:15:11 +0000") Message-ID: <86wny1q2g5.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2020 09:51:30 -0000 Giuliano Procida writes: > Hi. > > On Mon, 30 Nov 2020 at 15:56, Dodji Seketeli wrote: > >> Hello Giuliano, >> >> Giuliano Procida via Libabigail a =C3=A9crit= : >> >> > Hi Dodji. >> > >> > I had a quick scan through this. >> > >> > Do we need look_through_decl_only_enum somewhere as well? >> >> Good question. >> >> Right now, when the equals function compares enums, it doens't look >> through the declaration to get the definition of the enum. It will only >> use the decl-only part of the enum in the comparison, even if the enum >> decl was fully resolved to its definition. For classes (and unions) >> however, equals always looks through the declaration. >> >> So, at ABIXML write time, if we happen to not saving the definition and >> we only save the decl-only part, the comparison should be done between >> the decl-only part of both enums (the one in the IR coming from the >> binary and the one from the IR coming from the ABIXML) being compared. >> So it shouldn't yield an ABI change. >> >> Now, the behaviour for classes/unions can be said to be inconsistent wit= h >> the behaviour for enums. So we might indeed want to always serialize >> the definition of declarations of enum if we have it. >> >> But then, we'd need update at least the 'equals' comparison function >> accordingly, I believe. >> >> But as this is like getting into the "feature" territory (kind of) I'd >> wait for releasing 1.8 before doing this. >> >> What do you think? >> >> > I agree. TBH, in retrospect, all the forward-declared enum changes could > have waited. I can paste your comment into Bugzilla, but you might prefer > something else. Yeah, you can paste it there if you feel like it's useful :-) I don't think strongly either way :-) I live you decide. Thanks! --=20 =09=09Dodji