From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id E6E0C385DC0B for ; Thu, 14 May 2020 08:14:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E6E0C385DC0B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodj@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 8FFB2FF80D; Thu, 14 May 2020 08:14:05 +0000 (UTC) Received: by localhost (Postfix, from userid 1001) id 594801A4BA1; Thu, 14 May 2020 10:14:04 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, Matthias =?utf-8?Q?M=C3=A4nnich?= Subject: Re: [PATCH 0/4] Fix incomplete function type bug in abg-reader Organization: Me, myself and I References: <20200505180612.232158-1-gprocida@google.com> <865zczdhn5.fsf@seketeli.org> X-Operating-System: Red Hat Enterprise Linux Server 7.7 X-URL: http://www.seketeli.net/~dodji Date: Thu, 14 May 2020 10:14:04 +0200 In-Reply-To: (Giuliano Procida's message of "Wed, 13 May 2020 19:30:10 +0100") Message-ID: <86wo5faq7n.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 08:14:08 -0000 Hello, Giuliano Procida a =C3=A9crit: > The change to eliminate early canonicalisation has some residual value in > terms of code simplification. Let me know if you'd like me to adjust it a= nd > repost it with that as the aim. Otherwise, I'll leave it be. Early canonicalization was introduced because it does save time during canonicalization of big binaries. Presumably, one reason why you don't see its advantage when reading abixml files in practice at the moment is because abixml files are now (since quite recently) de-duplicated; meaning they contain each type just once. This de-duplication happens thanks to the type canonicalization that is done when reading binaries and the de-duplication work done at abixml writting time. But then, we still want to be able to read non-de-duplicated abixml files, canonicalize them efficiently and write them back in a de-duplicated form. So I prefer not applying that early canonicalization elimitation patch. It does introduce complexity, but that complexity is there for a reason. >> Below is what I think is the proper fix. >> >> Also, I filed this bug to track this issue >> https://sourceware.org/bugzilla/show_bug.cgi?id=3D25986, so that I can >> refer to it in the commit. >> >> Here is the patch that should fix your issue. Please tell me if it >> fixes your issue. If it does, then I'd prefer to apply this one. >> > > It clearly fixes the minimal test case. I've also run the code on some mu= ch > larger XML-XML comparisons both with and without --leaf-changes-only and = it > appears to fix the issue and not do anything else. So, yes, it does. Thank you for having tested it. I've applied it and closed the associated bug report. [...] Cheers, --=20 Dodji