public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@seketeli.org>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: Giuliano Procida <gprocida@google.com>,  libabigail@sourceware.org
Subject: Re: [PATCH] Add support for the CTF debug format to libabigail.
Date: Wed, 27 Oct 2021 11:19:04 +0200	[thread overview]
Message-ID: <86zgquzuyf.fsf@seketeli.org> (raw)
In-Reply-To: <8735p7sijh.fsf@oracle.com> (Jose E. Marchesi via Libabigail's message of "Mon, 11 Oct 2021 17:11:30 +0200")


[...]

"Jose E. Marchesi via Libabigail" <libabigail@sourceware.org> a écrit:

>>> - The libabigail tools assume that ELF means to always use DWARF to
>>>   generate the ABI IR.  We added a new command-line option --ctf to
>>>   the tools in order to make them to use the CTF debug info instead.
>>>   We are definitely not sure whether this is the best user interface.
>>>   In fact I would be suprised if it was ;)
>>>
>>> - We added support for --ctf to both abilint and abidiff.   We are not
>>>   sure whether it would make sense to add support for CTF to the other
>>>   tools.  Feedback welcome.

[...]

Giuliano Procida <gprocida@google.com> a écrit:

>> For ease of testing / building up a useful regression test suite, please do
>> consider adding --ctf to abidw (or adding abictf?) which would give a
>> CTF -> XML utility. Plain diff (rather than abilint's ABI diff) can be used to
>> check for changes over time.

"Jose E. Marchesi" <jose.marchesi@oracle.com> a ecrit

> What about renaming abitdw to something like abielf?  Then --ctf would
> fit well.

abidw was also a word play for "abi data write".  So we can just let it
as it is and add --ctf to it.  But if you feel strongly about it, we can
indeed change the name and provide an 'abidw' symlink for compatibility
purposes.  The new name could be 'abisrl' for 'abi serialize", or
something.

But we can discuss this later when the feature is in place.  For now, I
think the most important thing to do is to add the --ctf option to
abidw.

Ultimately, I think we can write some magic to detect the debuginfo
format associated with the binary and use it.  There will be cases where
it's hard to determine that.  For those cases, the --ctf or --dwarf (to
be added) options would be useful.

I hope this is helpful.

[...]

Cheers,

-- 
		Dodji

  parent reply	other threads:[~2021-10-27  9:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11  8:45 Jose E. Marchesi
2021-10-11 12:09 ` Giuliano Procida
2021-10-11 15:11   ` Jose E. Marchesi
2021-10-11 15:26     ` Giuliano Procida
2021-10-27  9:19     ` Dodji Seketeli [this message]
2021-10-27  8:59 ` Dodji Seketeli
2021-10-27 16:06   ` Jose E. Marchesi
2021-10-27 20:31   ` Ben Woodard
2021-10-29  9:35     ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zgquzuyf.fsf@seketeli.org \
    --to=dodji@seketeli.org \
    --cc=gprocida@google.com \
    --cc=jose.marchesi@oracle.com \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).