From: Dodji Seketeli <dodji@seketeli.org>
To: Chenxiong Qi <cqi@redhat.com>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH] Bug 20380 - Compare two local RPMs
Date: Fri, 01 Jan 2016 00:00:00 -0000 [thread overview]
Message-ID: <86zik12ov9.fsf@seketeli.org> (raw)
In-Reply-To: <6b784fbd-e2ae-52c3-aebc-ef18f371e880@redhat.com> (Chenxiong Qi's message of "Wed, 30 Nov 2016 21:18:28 +0800")
Hello Chenxiong,
Chenxiong Qi <cqi@redhat.com> a écrit:
> Patch[1] is updated with the new terms. Please review.
>
> [1]
> https://cqi.fedorapeople.org/libabigail/0001-Bug-20380-Compare-two-local-RPMs.patch
The patch looks good to me, thank you very much!
I have thus applied it to the master branch of the Git repository.
I have made some nitpicking changes, mostly to rename the the
RPMCollection.devel_debuginfo_rpms data member into
RPMCollection.ancillary_rpms and to adjust some comments.
I also have one question:
When you say this:
This patch allows developer to compare two local RPMs in form
fedabipkgdiff some/place/foo.rpm another/place/bar.rpm
But, network is still needed to talk with Koji.
Why do we need to talk to Koji if the two packages and *all* their
ancillary RPMs are present?
Cheers,
--
Dodji
next prev parent reply other threads:[~2016-12-12 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <718746663.1964037.1471008173635.JavaMail.zimbra@redhat.com>
2016-01-01 0:00 ` [Patch] " Chenxiong Qi
2016-01-01 0:00 ` [PATCH] Bug 20380 - " Chenxiong Qi
2016-01-01 0:00 ` Dodji Seketeli [this message]
2016-01-01 0:00 ` Chenxiong Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zik12ov9.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=cqi@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).