From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66769 invoked by alias); 12 Dec 2016 14:39:37 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 66757 invoked by uid 89); 12 Dec 2016 14:39:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=much X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: ms.seketeli.net From: Dodji Seketeli To: Chenxiong Qi Cc: libabigail@sourceware.org Subject: Re: [PATCH] Bug 20380 - Compare two local RPMs Organization: Me, myself and I References: <841561852.1964081.1471008200179.JavaMail.zimbra@redhat.com> <6b784fbd-e2ae-52c3-aebc-ef18f371e880@redhat.com> X-Operating-System: Red Hat Enterprise Linux Server 7.3 X-URL: http://www.seketeli.net/~dodji Date: Fri, 01 Jan 2016 00:00:00 -0000 In-Reply-To: <6b784fbd-e2ae-52c3-aebc-ef18f371e880@redhat.com> (Chenxiong Qi's message of "Wed, 30 Nov 2016 21:18:28 +0800") Message-ID: <86zik12ov9.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2016-q4/txt/msg00037.txt.bz2 Hello Chenxiong, Chenxiong Qi a =C3=A9crit: > Patch[1] is updated with the new terms. Please review. > > [1] > https://cqi.fedorapeople.org/libabigail/0001-Bug-20380-Compare-two-local-= RPMs.patch The patch looks good to me, thank you very much! I have thus applied it to the master branch of the Git repository. I have made some nitpicking changes, mostly to rename the the RPMCollection.devel_debuginfo_rpms data member into RPMCollection.ancillary_rpms and to adjust some comments. I also have one question: When you say this: This patch allows developer to compare two local RPMs in form fedabipkgdiff some/place/foo.rpm another/place/bar.rpm But, network is still needed to talk with Koji. Why do we need to talk to Koji if the two packages and *all* their ancillary RPMs are present? Cheers, --=20 Dodji