From: Dodji Seketeli <dodji@seketeli.org>
To: Mark Wielaard <mark@klomp.org>
Cc: Ben Woodard <woodard@redhat.com>,
Ben Woodard via Libabigail <libabigail@sourceware.org>
Subject: Re: libabigail 2.1 trunk testing where are we?
Date: Sun, 25 Sep 2022 09:06:41 +0200 [thread overview]
Message-ID: <871qs03pby.fsf@seketeli.org> (raw)
In-Reply-To: <6ab5b70c95e4c3169ac4ad678e5011baef52f05e.camel@klomp.org> (Mark Wielaard's message of "Tue, 20 Sep 2022 17:05:13 +0200")
Hey Mark,
Mark Wielaard <mark@klomp.org> a écrit:
[...]
>> I am guessing the reason why you chose to keep looking at the later has
>> to do with potential performance concerns?
>
> I am sure I fully understand your question.
>
> Do you mean if we could have used
> gelf_fsize (elf, ELF_T_DYN, 1, EV_CURRENT)
> all the time?
Yes.
> Yes, we could have simply done that. I didn't do that in the patch
> because that would have changed the existing code more. But maybe I
> should have done that and ignored the shdr completely to simplify
> things.
OK, that makes sense to me, thanks.
Cheers,
--
Dodji
prev parent reply other threads:[~2022-09-25 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 18:28 Ben Woodard
2022-07-29 20:57 ` Mark Wielaard
2022-07-29 22:48 ` Ben Woodard
2022-09-20 8:47 ` Dodji Seketeli
2022-09-20 15:05 ` Mark Wielaard
2022-09-25 7:06 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qs03pby.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=mark@klomp.org \
--cc=woodard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).