From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199])
	by sourceware.org (Postfix) with ESMTPS id 1428E3858C83
	for <libabigail@sourceware.org>; Sun, 25 Sep 2022 07:06:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1428E3858C83
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
	by mail.gandi.net (Postfix) with ESMTPSA id 0C753FF804;
	Sun, 25 Sep 2022 07:06:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org;
	s=gm1; t=1664089603;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cct8Za18VQXzOOMT7X8RxnQ8D3SG6apQbGutQ5Q8Vnc=;
	b=XB/NwyPFfIJnIjZY7wbC3tC8DJPmCDhSa6C8y6N6s7fSuc3X8cfnsbAi6TZHvh1DkkSFI9
	sexEjM4G2CQ89z70aIkG3MV4IQQYUaa97ERa7cp1tGdoQ2m1klArv9I/yVlyvSi7LYh2k3
	RT6kIAOOqwN37L05Nf6CR8/bamihtkRZrPptdLwuAgJiD+x+JFhYzB2OFtxge/G+zuYl0q
	LFovkVcB+WbUDNI6THBlvf8lgST6UXPHpy6/8nMggQbfZpyZK/73K+peo/9Kky42bXv+vQ
	2X466qfT1qHWYzwWuRu9OKy4P1fjxARvIsE1g80WqKATjpi99IBGs1K1X80JoQ==
Received: by localhost (Postfix, from userid 1000)
	id D725E581C2F; Sun, 25 Sep 2022 09:06:41 +0200 (CEST)
From: Dodji Seketeli <dodji@seketeli.org>
To: Mark Wielaard <mark@klomp.org>
Cc: Ben Woodard <woodard@redhat.com>,  Ben Woodard via Libabigail
 <libabigail@sourceware.org>
Subject: Re: libabigail 2.1 trunk testing where are we?
Organization: Me, myself and I
References: <5BA0C098-9E22-4604-8C13-1D0624B2489F@redhat.com>
	<YuRJpWXXz+I/BI08@wildebeest.org> <87y1ue5t5i.fsf@seketeli.org>
	<6ab5b70c95e4c3169ac4ad678e5011baef52f05e.camel@klomp.org>
X-Operating-System: Fedora 38
X-URL: http://www.seketeli.net/~dodji
Date: Sun, 25 Sep 2022 09:06:41 +0200
In-Reply-To: <6ab5b70c95e4c3169ac4ad678e5011baef52f05e.camel@klomp.org> (Mark
	Wielaard's message of "Tue, 20 Sep 2022 17:05:13 +0200")
Message-ID: <871qs03pby.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libabigail.sourceware.org>

Hey Mark,

Mark Wielaard <mark@klomp.org> a =C3=A9crit:

[...]

>> I am guessing the reason why you chose to keep looking at the later has
>> to do with potential performance concerns?
>
> I am sure I fully understand your question.
>
> Do you mean if we could have used
>   gelf_fsize (elf, ELF_T_DYN, 1, EV_CURRENT)
> all the time?

Yes.

> Yes, we could have simply done that. I didn't do that in the patch
> because that would have changed the existing code more. But maybe I
> should have done that and ignored the shdr completely to simplify
> things.

OK, that makes sense to me, thanks.

Cheers,

--=20
		Dodji