From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net
 [217.70.183.199])
 by sourceware.org (Postfix) with ESMTPS id 926A43858C60
 for <libabigail@sourceware.org>; Tue,  9 Nov 2021 11:30:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 926A43858C60
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
 by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 86D7BFF811;
 Tue,  9 Nov 2021 11:30:33 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 9FDF358010A; Tue,  9 Nov 2021 12:30:32 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: tangmeng <tangmeng@uniontech.com>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH v2] make abicompat test happy
Organization: Me, myself and I
References: <20211108020017.26436-1-tangmeng@uniontech.com>
X-Operating-System: Fedora 36
X-URL: http://www.seketeli.net/~dodji
Date: Tue, 09 Nov 2021 12:30:32 +0100
In-Reply-To: <20211108020017.26436-1-tangmeng@uniontech.com>
 (tangmeng@uniontech.com's message of "Mon, 8 Nov 2021 10:00:17 +0800")
Message-ID: <871r3p8t2f.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Nov 2021 11:30:37 -0000

Hello,

tangmeng <tangmeng@uniontech.com> a =C3=A9crit:

[...]

> +
> +      if (is_ok)
> +        {
> +          cout << "\e[1;33mTest PASSED: \033[0m" << cmd << "\n";

Hehe, bells and whistles ... :-)

I'd prefer to have the escape sequences be "self-documented" so that the
intent is clear enough.  For instance:

#define BRIGHT_YELLOW_COLOR "\a1;33m"
#define DEFAULT_TERMINAL_COLOR "\033[0m"

and then you'd you'd emit colored messages like:

cout << BRIGHT_YELLOW_COLOR
     << "Test Passed:"
     << DEFAULT_TERMINAL_COLOR
     << cmd
     << std::endl;

I believe that is more self explanatory for someone who reads the code.

Could you please use that kind of style ?

Thanks a lot for your work, by the way, it's highly appreciated!

Cheers,

--=20
		Dodji