From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, gprocida@google.com,
kernel-team@android.com
Subject: Re: [PATCH 20/20] symtab: Add support for MODVERSIONS (CRC checksums)
Date: Fri, 19 Mar 2021 19:15:59 +0100 [thread overview]
Message-ID: <871rcbvwkg.fsf@seketeli.org> (raw)
In-Reply-To: <20210127125853.886677-21-maennich@google.com> (Matthias Maennich's message of "Wed, 27 Jan 2021 12:58:53 +0000")
Matthias Maennich <maennich@google.com> a écrit:
[...]
> diff --git a/src/abg-ir.cc b/src/abg-ir.cc
> index 0b31f2014189..64dfffbf4011 100644
> --- a/src/abg-ir.cc
> +++ b/src/abg-ir.cc
[...]
> @@ -1414,6 +1419,7 @@ elf_symbol::elf_symbol(const environment* e,
> visibility vi,
> bool is_linux_string_cst,
> bool is_in_ksymtab,
> + uint64_t crc,
Please add a comment for this new parameter.
> bool is_suppressed)
> : priv_(new priv(e,
> i,
> @@ -1427,6 +1433,7 @@ elf_symbol::elf_symbol(const environment* e,
> vi,
> is_linux_string_cst,
> is_in_ksymtab,
> + crc,
Likewise.
> is_suppressed))
> {}
>
> @@ -1486,11 +1493,12 @@ elf_symbol::create(const environment* e,
> visibility vi,
> bool is_linux_string_cst,
> bool is_in_ksymtab,
> + uint64_t crc,
Likewise.
[...]
> +uint64_t
> +elf_symbol::get_crc() const
> +{return priv_->crc_;}
> +
> +void
> +elf_symbol::set_crc(uint64_t crc)
> +{priv_->crc_ = crc;}
> +
Please add a comment for these two accessors.
[...]
> diff --git a/src/abg-symtab-reader.cc b/src/abg-symtab-reader.cc
> index 512fbc20adc0..8ee90c590a94 100644
> --- a/src/abg-symtab-reader.cc
> +++ b/src/abg-symtab-reader.cc
> @@ -12,6 +12,7 @@
[...]
> @@ -338,6 +345,18 @@ symtab::load_(Elf* elf_handle,
> has_ksymtab_entries_ = true;
> }
>
> + // Now add the CRC values
> + for (const auto& crc_entry : crc_values)
> + {
> + const auto r = name_symbol_map_.find(crc_entry.first);
> + if (r == name_symbol_map_.end())
> + continue;
> +
> + for (const auto& symbol : r->second) {
The opening parenthesis is useless (and should have go on the next line
if it was not)
> + symbol->set_crc(crc_entry.second);
> + }
> + }
> +
> // sort the symbols for deterministic output
> std::sort(symbols_.begin(), symbols_.end(), symbol_sort);
>
[...]
>
> * include/abg-ir.h (elf_symbol::elf_symbol): Add CRC parameter.
> (elf_symbol::create): Likewise.
> (elf_symbol::get_crc): New member method.
> (elf_symbol::set_crc): New member method.
> * src/abg-comp-filter.cc (crc_changed): New function.
> (categorize_harmful_diff_node): Also test for CRC changes.
> * src/abg-ir.cc (elf_symbol::priv::crc_): New data member.
> * src/abg-ir.cc (elf_symbol::priv::priv): Add CRC parameter.
> (elf_symbol::elf_symbol): Likewise.
> (elf_symbol::create): Likewise.
> (elf_symbol::textually_equals): Add CRC support.
> (elf_symbol::get_crc): New member method.
> (elf_symbol::set_crc): New member method.
> * src/abg-reader.cc (build_elf_symbol): Add CRC support.
> * src/abg-reporter-priv.cc (maybe_report_diff_for_symbol): Likewise.
> * src/abg-symtab-reader.cc (symtab::load): Likewise.
> * src/abg-writer.cc (write_elf_symbol): Likewise.
> * tests/data/Makefile.am: Add new test data files.
> * tests/data/test-abidiff-exit/test-crc-report.txt: New test file.
> * tests/data/test-abidiff-exit/test-crc-v0.abi: Likewise.
> * tests/data/test-abidiff-exit/test-crc-v1.abi: Likewise.
> * tests/data/test-abidiff/empty-report.txt: New file.
> * tests/data/test-abidiff/test-PR18166-libtirpc.so.report.txt: Deleted.
> * tests/data/test-abidiff/test-PR24552-report0.txt: Deleted.
> * tests/data/test-abidiff/test-crc-0.xml: New test file.
> * tests/data/test-abidiff/test-crc-1.xml: Likewise.
> * tests/data/test-abidiff/test-crc-2.xml: Likewise.
> * tests/data/test-abidiff/test-crc-report.txt: Likewise.
> * tests/data/test-abidiff/test-empty-corpus-report.txt: Deleted.
> * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Add CRC values.
> * tests/data/test-read-write/test-crc.xml: New test data file.
> * tests/data/test-symtab/kernel-modversions/Makefile: New test source.
> * tests/data/test-symtab/kernel-modversions/one_of_each.c: Likewise.
> * tests/data/test-symtab/kernel-modversions/one_of_each.ko: Likewise.
> * tests/test-abidiff-exit.cc: Add new test case.
> * tests/test-abidiff.cc: Add new test case.
> * tests/test-read-write.cc: Likewise.
> * tests/test-symtab.cc (Symtab::KernelSymtabsWithCRC): New test case.
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>
OK to apply to master once the pre-requisites are in.
Thanks!
[...]
Cheers,
--
Dodji
next prev parent reply other threads:[~2021-03-21 11:59 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 21:42 [PATCH v1 00/16] Refactor (k)symtab reader Matthias Maennich
2020-06-19 21:42 ` [PATCH v1 01/16] abg-cxx-compat: add simplified version of std::optional Matthias Maennich
2020-06-19 21:42 ` [PATCH v1 02/16] abg-cxx-compat: more <functional> support: std::bind and friends Matthias Maennich
2020-06-19 21:42 ` [PATCH v1 03/16] abg-ir: elf_symbol: add is_in_ksymtab field Matthias Maennich
2020-06-19 21:42 ` [PATCH v1 04/16] abg-ir: elf_symbol: add is_suppressed field Matthias Maennich
2020-06-22 9:46 ` Giuliano Procida
2020-06-19 21:42 ` [PATCH v1 05/16] dwarf-reader split: create abg-symtab-reader.{h, cc} and test case Matthias Maennich
2020-06-19 21:42 ` [PATCH v1 06/16] Refactor ELF symbol table reading by adding a new symtab reader Matthias Maennich
2020-06-19 21:42 ` [PATCH v1 07/16] Integrate new symtab reader into corpus and read_context Matthias Maennich
2020-06-19 21:42 ` [PATCH v1 08/16] corpus: make get_(undefined_)?_(var|fun)_symbols use the new symtab Matthias Maennich
2020-06-22 9:53 ` Giuliano Procida
2020-06-19 21:42 ` [PATCH v1 09/16] corpus: make get_unreferenced_(function|variable)_symbols " Matthias Maennich
2020-06-19 21:42 ` [PATCH v1 10/16] abg-reader: avoid using the (var|function)_symbol_map Matthias Maennich
2020-06-19 21:43 ` [PATCH v1 11/16] dwarf-reader: read_context: use new symtab in *_symbols_is_exported Matthias Maennich
2020-06-19 21:43 ` [PATCH v1 12/16] Switch kernel stuff over to new symtab and drop unused code Matthias Maennich
2020-06-19 21:43 ` [PATCH v1 13/16] abg-elf-helpers: migrate ppc64 specific helpers Matthias Maennich
2020-06-19 21:43 ` [PATCH v1 14/16] symtab_reader: add support for ppc64 ELFv1 binaries Matthias Maennich
2020-06-19 21:43 ` [PATCH v1 15/16] abg-corpus: remove symbol maps and their setters Matthias Maennich
2020-06-19 21:43 ` [PATCH v1 16/16] dwarf reader: drop (now) unused code related symbol table reading Matthias Maennich
2020-06-22 9:56 ` Giuliano Procida
2020-07-03 16:46 ` [PATCH v2 00/21] Refactor (k)symtab reader Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 01/21] abg-cxx-compat: add simplified version of std::optional Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 02/21] abg-cxx-compat: more <functional> support: std::bind and friends Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 03/21] abg-ir: elf_symbol: add is_in_ksymtab field Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 04/21] abg-ir: elf_symbol: add is_suppressed field Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 05/21] dwarf-reader split: create abg-symtab-reader.{h, cc} and test case Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 06/21] Refactor ELF symbol table reading by adding a new symtab reader Matthias Maennich
2020-07-20 15:39 ` Dodji Seketeli
2020-07-03 16:46 ` [PATCH v2 07/21] Integrate new symtab reader into corpus and read_context Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 08/21] corpus: make get_(undefined_)?_(var|fun)_symbols use the new symtab Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 09/21] corpus: make get_unreferenced_(function|variable)_symbols " Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 10/21] abg-reader: avoid using the (var|function)_symbol_map Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 11/21] dwarf-reader: read_context: use new symtab in *_symbols_is_exported Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 12/21] Switch kernel stuff over to new symtab and drop unused code Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 13/21] abg-elf-helpers: migrate ppc64 specific helpers Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 14/21] symtab_reader: add support for ppc64 ELFv1 binaries Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 15/21] abg-corpus: remove symbol maps and their setters Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 16/21] dwarf reader: drop now-unused code related to symbol table reading Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 17/21] test-symtab: add tests for whitelisted functions Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 18/21] symtab/dwarf-reader: allow hinting of main symbols for aliases Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 19/21] dwarf-reader/writer: consider aliases when dealing with suppressions Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 20/21] symtab: Add support for MODVERSIONS (CRC checksums) Matthias Maennich
2020-07-03 16:46 ` [PATCH v2 21/21] reader/symtab: Improve handling for suppressed aliases Matthias Maennich
2020-07-20 14:27 ` [PATCH v2 00/21] Refactor (k)symtab reader Dodji Seketeli
2021-01-27 12:58 ` [PATCH 00/20] " Matthias Maennich
2021-01-27 12:58 ` [PATCH 01/20] abg-cxx-compat: add simplified version of std::optional Matthias Maennich
2021-03-09 9:43 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 02/20] abg-ir: elf_symbol: add is_in_ksymtab field Matthias Maennich
2021-03-09 14:05 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 03/20] abg-ir: elf_symbol: add is_suppressed field Matthias Maennich
2021-03-09 18:03 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 04/20] dwarf-reader split: create abg-symtab-reader.{h, cc} and test case Matthias Maennich
2021-03-10 18:00 ` [PATCH 04/20] dwarf-reader split: create abg-symtab-reader.{h,cc} " Dodji Seketeli
2021-01-27 12:58 ` [PATCH 05/20] Refactor ELF symbol table reading by adding a new symtab reader Matthias Maennich
2021-03-12 11:18 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 06/20] Integrate new symtab reader into corpus and read_context Matthias Maennich
2021-03-12 15:04 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 07/20] corpus: make get_(undefined_)?_(var|fun)_symbols use the new symtab Matthias Maennich
2021-03-15 10:05 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 08/20] corpus: make get_unreferenced_(function|variable)_symbols " Matthias Maennich
2021-03-15 12:06 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 09/20] abg-reader: avoid using the (var|function)_symbol_map Matthias Maennich
2021-03-15 14:23 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 10/20] dwarf-reader: read_context: use new symtab in *_symbols_is_exported Matthias Maennich
2021-03-15 18:13 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 11/20] Switch kernel stuff over to new symtab and drop unused code Matthias Maennich
2021-03-16 10:38 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 12/20] abg-elf-helpers: migrate ppc64 specific helpers Matthias Maennich
2021-03-16 10:59 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 13/20] symtab_reader: add support for ppc64 ELFv1 binaries Matthias Maennich
2021-03-16 11:39 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 14/20] abg-corpus: remove symbol maps and their setters Matthias Maennich
2021-03-16 18:08 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 15/20] dwarf reader: drop (now) unused code related to symbol table reading Matthias Maennich
2021-03-16 18:42 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 16/20] test-symtab: add tests for whitelisted functions Matthias Maennich
2021-03-17 11:07 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 17/20] symtab/dwarf-reader: allow hinting of main symbols for aliases Matthias Maennich
2021-03-17 13:40 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 18/20] dwarf-reader/writer: consider aliases when dealing with suppressions Matthias Maennich
2021-03-17 15:44 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 19/20] abg-writer.cc: fix write_elf_symbol_reference loop Matthias Maennich
2021-03-17 16:11 ` Dodji Seketeli
2021-01-27 12:58 ` [PATCH 20/20] symtab: Add support for MODVERSIONS (CRC checksums) Matthias Maennich
2021-03-17 17:13 ` Dodji Seketeli
2021-03-17 23:29 ` Giuliano Procida
2021-03-18 22:10 ` Matthias Maennich
2021-03-19 16:55 ` Dodji Seketeli
2021-03-19 18:15 ` Dodji Seketeli [this message]
2021-03-29 13:19 ` [GIT PULL] Refactor (k)symtab reader Matthias Maennich
2021-04-02 14:28 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rcbvwkg.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).