From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by sourceware.org (Postfix) with ESMTPS id C6BCC3870867 for ; Tue, 9 Mar 2021 09:43:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C6BCC3870867 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodji@seketeli.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id E073510000A; Tue, 9 Mar 2021 09:43:19 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 661B3580101; Tue, 9 Mar 2021 10:43:01 +0100 (CET) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 01/20] abg-cxx-compat: add simplified version of std::optional Organization: Me, myself and I References: <20200619214305.562-1-maennich@google.com> <20210127125853.886677-1-maennich@google.com> <20210127125853.886677-2-maennich@google.com> X-Operating-System: Fedora 34 X-URL: http://www.seketeli.net/~dodji Date: Tue, 09 Mar 2021 10:43:01 +0100 In-Reply-To: <20210127125853.886677-2-maennich@google.com> (Matthias Maennich's message of "Wed, 27 Jan 2021 12:58:34 +0000") Message-ID: <871rco1x3u.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2021 09:43:23 -0000 Matthias Maennich a =C3=A9crit: > In the absence (but desire) of std::optional, add a simplified > version of it to abg_compat:: in case we are compiling with a pre-C++17 > standard. Otherwise use std::optional from directly. > > This is being used by a later patch and serves as a prerequisite. > It only serves the purpose of being a compatibility implementation and > does not claim to be complete at all. Just enough for the project's > needs. > > * include/abg-cxx-compat.h (abg_compat::optional): Add new class. > * tests/tests-cxx-compat.cc: Add new test cases. > > Reviewed-by: Giuliano Procida > Signed-off-by: Matthias Maennich Applied to master, thanks! Cheers, [...] --=20 Dodji