From: Dodji Seketeli <dodji@redhat.com>
To: Dodji Seketeli <dodji@redhat.com>
Cc: libabigail@sourceware.org, ckalina@redhat.com
Subject: [PATCH 07/13] Misc white space fixes
Date: Thu, 02 Mar 2023 20:00:27 +0100 [thread overview]
Message-ID: <87356nq8qc.fsf_-_@redhat.com> (raw)
In-Reply-To: <87356nrnmq.fsf@redhat.com> (Dodji Seketeli's message of "Thu, 02 Mar 2023 19:53:17 +0100")
Hello,
* include/abg-suppression.h (class
type_suppression::insertion_range::end): Fix indentation.
* src/abg-default-reporter.cc (default_reporter::report): Fix
indentation in the overload for corpus_diff.
* src/abg-suppression-priv.h
(type_suppression::priv::source_locations_to_keep_): Fix alignment.
* src/abg-suppression.cc (read_type_suppression): Fix alignment of
comment.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
include/abg-suppression.h | 2 +-
src/abg-default-reporter.cc | 4 ++--
src/abg-suppression-priv.h | 2 +-
src/abg-suppression.cc | 6 +++---
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/abg-suppression.h b/include/abg-suppression.h
index 05b0e8b4..9449d06d 100644
--- a/include/abg-suppression.h
+++ b/include/abg-suppression.h
@@ -379,7 +379,7 @@ public:
begin() const;
boundary_sptr
- end() const;
+ end() const;
static insertion_range::integer_boundary_sptr
create_integer_boundary(int value);
diff --git a/src/abg-default-reporter.cc b/src/abg-default-reporter.cc
index 243ddbfb..38b89e62 100644
--- a/src/abg-default-reporter.cc
+++ b/src/abg-default-reporter.cc
@@ -1873,7 +1873,7 @@ default_reporter::report(const corpus_diff& d, ostream& out,
// was playing tricks with symbol names and
// versions).
(is_c_language(get_translation_unit(fn)->get_language())
- && fn->get_name() != fn->get_symbol()->get_name()))
+ && fn->get_name() != fn->get_symbol()->get_name()))
{
// As the name of the symbol of the function doesn't
// seem to be obvious here, make sure to tell the
@@ -1949,7 +1949,7 @@ default_reporter::report(const corpus_diff& d, ostream& out,
emitted = true;
}
if (emitted)
- out << "\n";
+ out << "\n";
}
if (ctxt->show_added_vars())
diff --git a/src/abg-suppression-priv.h b/src/abg-suppression-priv.h
index dcc5cc53..cf66a9f1 100644
--- a/src/abg-suppression-priv.h
+++ b/src/abg-suppression-priv.h
@@ -581,7 +581,7 @@ class type_suppression::priv
// members of the class.
mutable regex::regex_t_sptr potential_data_members_regex_;
type_suppression::insertion_ranges insertion_ranges_;
- unordered_set<string> source_locations_to_keep_;
+ unordered_set<string> source_locations_to_keep_;
string source_location_to_keep_regex_str_;
mutable regex::regex_t_sptr source_location_to_keep_regex_;
mutable vector<string> changed_enumerator_names_;
diff --git a/src/abg-suppression.cc b/src/abg-suppression.cc
index aaf175ca..4ed42e82 100644
--- a/src/abg-suppression.cc
+++ b/src/abg-suppression.cc
@@ -2007,9 +2007,9 @@ read_type_suppression(const ini::config::section& section)
// and not (for instance):
// has_data_member_inserted_between = {{0 , end}, {1, foo}}
//
- // This means that the tuple_property_value contains just one
- // value, which is a list_property that itself contains 2
- // values.
+ // This means that the tuple_property_value contains just one
+ // value, which is a list_property that itself contains 2
+ // values.
type_suppression::insertion_range::boundary_sptr begin, end;
ini::tuple_property_value_sptr v = prop->get_value();
if (v
--
2.39.2
--
Dodji
next prev parent reply other threads:[~2023-03-02 19:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <877cvzrnws.fsf@redhat.com>
2023-03-02 18:53 ` [PATCH 00/13] Support negative suppression specifications Dodji Seketeli
2023-03-02 18:55 ` [PATCH 01/13] ini: Fix parsing list property values Dodji Seketeli
2023-03-02 18:56 ` [PATCH 02/13] suppr: Support has_data_member and has_data_member_regexp properties Dodji Seketeli
2023-03-02 18:57 ` [PATCH 03/13] suppression: Factorize out is_data_member_offset_in_range Dodji Seketeli
2023-03-02 18:58 ` [PATCH 04/13] suppression: Support the has_size_change property for suppress_type Dodji Seketeli
2023-03-02 18:59 ` [PATCH 05/13] suppression: Support offset_of_{first,last}_data_member_regexp offset selectors Dodji Seketeli
2023-03-02 18:59 ` [PATCH 06/13] comparison, suppression: Support [allow_type] directive Dodji Seketeli
2023-03-02 19:00 ` Dodji Seketeli [this message]
2023-03-02 19:01 ` [PATCH 08/13] abidiff: Add extensive logging Dodji Seketeli
2023-03-02 19:01 ` [PATCH 09/13] tools-utils: Support kernel stablelist Dodji Seketeli
2023-03-02 19:02 ` [PATCH 10/13] comp-filter: Don't re-visit node while applying filters to diff nodes Dodji Seketeli
2023-03-02 19:03 ` [PATCH 11/13] comparison: Add a mode to not apply filters on interface sub-graphs Dodji Seketeli
2023-03-02 19:04 ` [PATCH 12/13] comparison: When marking leaf nodes don't do unnecessary impact analysis Dodji Seketeli
2023-03-02 19:05 ` [PATCH 13/13] comp-filter: Speed up harmless/harmful categorization Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87356nq8qc.fsf_-_@redhat.com \
--to=dodji@redhat.com \
--cc=ckalina@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).