From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by sourceware.org (Postfix) with ESMTPS id 0B443386F0EF for ; Thu, 30 Jun 2022 16:40:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B443386F0EF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id C41FF24000C; Thu, 30 Jun 2022 16:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1656607214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XPWMjfKhINm5ON+d6vxKcHVDJdunUtVokrmUlfUtehQ=; b=ohmpxoI5YW9KZYFdpsvpul5xQjuGAs2Es8qwovH7Fy19QP4GsNQxXJ3KN0/jlgOKgrR9Ln ORQevrbozXLWlrPOCpdcp/NMtcGsW7OdsZFNW2c7rKCj4qQhvRAJtJAiSUPEtBJ+TkEfHB gwAxt1R7BPI1YeovhAdavgDI1JGAI9PNTjV6tpvSo99B4ycEXV+62IRDnmmsQP5TarOnt0 3r5DSIeC0H7cFC8st9pxnR/A3lj75SlohZAdrUfn/cunVZZWa2UV2lL2Zdcf76TLdTduBu hHN+dto5ZDyo5qLBmhxcM+jaxoJU8X7rg+NM0qCP/v1kV8rtdrjSg4IcFH0H/g== Received: by localhost (Postfix, from userid 1000) id 134F15802B4; Thu, 30 Jun 2022 18:40:13 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH v5 1/4] crc_changed: eliminate copying of shared_ptr values Organization: Me, myself and I References: <20220321160221.1372398-1-gprocida@google.com> <20220613142533.3676501-2-gprocida@google.com> X-Operating-System: Fedora 37 X-URL: http://www.seketeli.net/~dodji Date: Thu, 30 Jun 2022 18:40:12 +0200 In-Reply-To: <20220613142533.3676501-2-gprocida@google.com> (Giuliano Procida's message of "Mon, 13 Jun 2022 15:25:30 +0100") Message-ID: <8735fmds0j.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 16:40:17 -0000 Hello, Giuliano Procida a =C3=A9crit: > As pointed out in a review of similar code, it is possible to avoid > copying a couple of shared pointers in this function, by taking > references instead. > > This commit also splits declarations to one per line and removes the > unnecessary parentheses around the return expression. > > * src/abg-comp-filter.cc (crc_changed): Take references to > avoid std::shared_ptr copying. Split declarations into one per > line. Remove unnecessary return expression parentheses. > > Reviewed-by: Matthias Maennich > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji