From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by sourceware.org (Postfix) with ESMTPS id 3AEDC3858C54 for ; Tue, 12 Apr 2022 16:16:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AEDC3858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 559DA100004; Tue, 12 Apr 2022 16:16:55 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 94935581C31; Tue, 12 Apr 2022 18:16:54 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: Thomas Schwinge , Giuliano Procida via Libabigail , Mark Wielaard Subject: Re: 'src/abg-dwarf-reader.cc:compare_dies_string_attribute_value' optimization Organization: Me, myself and I References: <87wnijv616.fsf@dirichlet.schwinge.homeip.net> <87r18oynpn.fsf@euler.schwinge.homeip.net> <877d7vhcmv.fsf@seketeli.org> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Tue, 12 Apr 2022 18:16:54 +0200 In-Reply-To: (Giuliano Procida's message of "Tue, 12 Apr 2022 16:20:51 +0100") Message-ID: <8735iigtu1.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 16:17:01 -0000 Giuliano Procida a =C3=A9crit: > I started looking at this today but I've run out of time. I'll be able to > take another look in about a week. Thanks a lot. > Checks fail (various types are renumbered in XML output) starting at > commit 57b1c714. Yeah, that is unfortunately expected because ... > I haven't tried this on kernel or framework libraries yet, but I know the= re > are plenty of typedefs in both. ... of this exactly. This typedef change has been on my radar for a long time. The fact that a type Foo would use a typedef T in one version and a typedef T' in another once, where T and T' have the same underlying type would result in the two instances of Foo to be different can wreak havoc on the self check tests, where in reality the two types are not different from an ABI standpoint. I am hoping that this is one of those changes that will get us closer to having more stable abixml output. Please note however that you need the entire stack of changes to have everything working "as expected", as far as I can tell. Thank you for looking into this. --=20 Dodji