From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by sourceware.org (Postfix) with ESMTPS id 28ADF3857824 for ; Tue, 21 Dec 2021 16:22:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28ADF3857824 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 3D695100007; Tue, 21 Dec 2021 16:22:34 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 5ED3A581C2E; Tue, 21 Dec 2021 17:22:33 +0100 (CET) From: Dodji Seketeli To: "Guillermo E. Martinez via Libabigail" Subject: Re: [PATCH] ctf-reader: Assert on ir::hash_as_canonical_type_or_constant Organization: Me, myself and I References: <20211210025252.2309157-1-guillermo.e.martinez@oracle.com> X-Operating-System: Fedora 36 X-URL: http://www.seketeli.net/~dodji Date: Tue, 21 Dec 2021 17:22:33 +0100 In-Reply-To: <20211210025252.2309157-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Thu, 9 Dec 2021 20:52:52 -0600") Message-ID: <8735mm7ws6.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 16:22:37 -0000 Hello Guillermo, "Guillermo E. Martinez via Libabigail" a =C3=A9crit: [...] Thanks for the patch! I have tested this patch and I've found some issues. Please find my comments below: > diff --git a/tests/test-read-ctf.cc b/tests/test-read-ctf.cc > index b448ddc5..7f5381f6 100644 > --- a/tests/test-read-ctf.cc > +++ b/tests/test-read-ctf.cc > @@ -220,6 +220,54 @@ static InOutSpec in_out_specs[] =3D > "data/test-read-ctf/PR27700/test-PR27700.abi", > "output/test-read-ctf/PR27700/test-PR27700.abi", > }, > + { > + "data/test-read-ctf/test-callback.o", This *.o is not present in the patch. I think the remaining *.o below are not present in the patch either. So test/runtestreadctf fails. Also, you need to add these files to the tests/data/Makefile.am file. As I've said elsewhere in the past, "make distcheck-fast" can help you check if the files are really present in the tarball. [...] Cheers, --=20 Dodji