From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mslow2.mail.gandi.net (mslow2.mail.gandi.net [217.70.178.242]) by sourceware.org (Postfix) with ESMTPS id 8ABF6387085C for ; Mon, 29 Jun 2020 10:03:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8ABF6387085C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org Received: from relay3-d.mail.gandi.net (unknown [217.70.183.195]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 730DF3A58E3 for ; Mon, 29 Jun 2020 09:14:14 +0000 (UTC) X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 8978B60002; Mon, 29 Jun 2020 09:08:51 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 1C19F1800938; Mon, 29 Jun 2020 11:08:50 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 04/11] Tidy build_enum_type state variables. Organization: Me, myself and I References: <20200610115940.26035-1-gprocida@google.com> <20200610115940.26035-5-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.seketeli.net/~dodji Date: Mon, 29 Jun 2020 11:08:50 +0200 In-Reply-To: <20200610115940.26035-5-gprocida@google.com> (Giuliano Procida's message of "Wed, 10 Jun 2020 12:59:33 +0100") Message-ID: <87366eutlp.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 10:03:55 -0000 Giuliano Procida a =C3=A9crit: > This patch brings the enum code closer to the class/union code, in the > hope that this will ease future code maintenance. > > There are no behavioural changes. > > * src/abg-dwarf-reader.cc (build_enum_type): Rename local > variable enum_is_anonymous to is_anonymous. Move initilisation > of local variable is_artificial to location corresponding to > that in add_or_update_class_type and add_or_update_union_type > functions. > > Signed-off-by: Giuliano Procida Applied to master, thanks! Cheers, --=20 Dodji