From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH 1/3] abidiff: Remove blank line after typedef changes.
Date: Wed, 01 Apr 2020 18:21:54 +0200 [thread overview]
Message-ID: <87369nqiql.fsf@seketeli.org> (raw)
In-Reply-To: <20200329170121.188147-1-gprocida@google.com> (Giuliano Procida's message of "Sun, 29 Mar 2020 18:01:19 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
> This patch removes perhaps the last remaining cause of double blank
> lines in output.
>
> The state variable emit_nl was being set to true just after emitting a
> new line which resulted in a blank line after every local typedef
> change report.
>
> * include/abg-reporter.h
> (default_reporter::report_local_typedef_changes): Change
> return type to void.
> * src/abg-default-reporter.cc:
> (default_reporter::report_local_typedef_changes): Change
> return type to void, remove emit_nl state variable and logic.
> * tests/data/test-abidiff/test-PR18791-report0.txt: Remove
> blank lines.
> * tests/data/test-diff-dwarf/test42-PR21296-clanggcc-report0.txt:
> Ditto.
> * tests/data/test-diff-suppr/test39-opaque-type-report-0.txt:
> Ditto.
Applied to master, thanks!!
Cheers,
--
Dodji
prev parent reply other threads:[~2020-04-01 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 17:01 Giuliano Procida
2020-03-29 17:01 ` [PATCH 2/3] test-diff-suppr.cc: Add missing tests Giuliano Procida
2020-03-29 17:30 ` Matthias Maennich
2020-04-01 16:46 ` Dodji Seketeli
2020-03-29 17:01 ` [PATCH 3/3] abidiffpkg: Remove stray test report file Giuliano Procida
2020-03-29 17:31 ` Matthias Maennich
2020-04-01 17:31 ` Dodji Seketeli
2020-03-29 17:30 ` [PATCH 1/3] abidiff: Remove blank line after typedef changes Matthias Maennich
2020-04-01 16:21 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87369nqiql.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).