From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116214 invoked by alias); 25 Jul 2019 09:03:35 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 116139 invoked by uid 89); 25 Jul 2019 09:03:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: relay12.mail.gandi.net Received: from relay12.mail.gandi.net (HELO relay12.mail.gandi.net) (217.70.178.232) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jul 2019 09:03:31 +0000 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 28F36200003; Thu, 25 Jul 2019 09:03:28 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 1F92718009D3; Thu, 25 Jul 2019 11:03:27 +0200 (CEST) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, kernel-team@android.com, Alessio Balsini Subject: Re: [PATCH v1] abg-dwarf-reader: detect kernel modules without exports as such Organization: Me, myself and I References: <20190724213255.182046-1-maennich@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.6 X-URL: http://www.seketeli.net/~dodji Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <20190724213255.182046-1-maennich@google.com> (Matthias Maennich's message of "Wed, 24 Jul 2019 22:32:55 +0100") Message-ID: <8736iuqye9.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00019.txt.bz2 Hello, Matthias Maennich a =C3=A9crit: [...] > > * src/abg-dwarf-reader.cc(is_linux_kernel_binary): consider > binaries only having a .modinfo section to be kernel binaries This looks good to me and has been pushed to master. Thanks a lot. Cheers, --=20 Dodji