From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230])
 by sourceware.org (Postfix) with ESMTPS id 156B13858C27
 for <libabigail@sourceware.org>; Mon, 15 Mar 2021 14:23:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 156B13858C27
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=dodji@seketeli.org
Received: from localhost (unknown [88.120.130.27])
 (Authenticated sender: dodji@seketeli.org)
 by relay10.mail.gandi.net (Postfix) with ESMTPSA id 3DA53240007;
 Mon, 15 Mar 2021 14:23:25 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 8013A58000E; Mon, 15 Mar 2021 15:23:25 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org,  gprocida@google.com,  kernel-team@android.com
Subject: Re: [PATCH 09/20] abg-reader: avoid using the
 (var|function)_symbol_map
Organization: Me, myself and I
References: <20200619214305.562-1-maennich@google.com>
 <20210127125853.886677-1-maennich@google.com>
 <20210127125853.886677-10-maennich@google.com>
X-Operating-System: Fedora 34
X-URL: http://www.seketeli.net/~dodji
Date: Mon, 15 Mar 2021 15:23:25 +0100
In-Reply-To: <20210127125853.886677-10-maennich@google.com> (Matthias
 Maennich's message of "Wed, 27 Jan 2021 12:58:42 +0000")
Message-ID: <874khczeaq.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Mar 2021 14:23:29 -0000

Matthias Maennich <maennich@google.com> a =C3=A9crit:

> Instead of using the corpus var|function_symbol_maps for symbol lookups,
> let build_elf_symbol_from_reference use the symtab::lookup_symbol
> method. That leads to a shorter implementation and we can drop the
> indicative parameter.
>
> 	* src/abg-reader.cc (build_elf_symbol_from_reference): drop
> 	  last parameter indicating the lookup type and use corpus
> 	  symtab for the lookup
> 	  (build_function_decl): Adjust accordingly.
> 	  (build_var_decl): Likewise.
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>

OK to apply to master once the pre-requisite patches are in.

Thanks!

[...]

Cheers,

--=20
		Dodji