From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id 976B73858005 for ; Wed, 28 Oct 2020 09:30:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 976B73858005 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.65 Received: from localhost (91-166-131-65.subs.proxad.net [91.166.131.65]) (Authenticated sender: dodji@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B8F36FF816; Wed, 28 Oct 2020 09:30:13 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 8E0605800FC; Wed, 28 Oct 2020 10:30:12 +0100 (CET) From: Dodji Seketeli To: Mark Wielaard Cc: libabigail@sourceware.org Subject: Re: Buildbot failure in Wildebeest Builder on whole buildset Organization: Me, myself and I References: <20201027094717.EE7B990EAEB@builder.wildebeest.org> <23c2d7d59403327398ec4885150334e7902c1526.camel@klomp.org> <55435f4245c90de7b3e68997aaa085d12765ea7b.camel@klomp.org> X-Operating-System: Fedora 34 X-URL: http://www.seketeli.net/~dodji Date: Wed, 28 Oct 2020 10:30:12 +0100 In-Reply-To: <55435f4245c90de7b3e68997aaa085d12765ea7b.camel@klomp.org> (Mark Wielaard's message of "Tue, 27 Oct 2020 14:12:37 +0100") Message-ID: <874kmeaeaj.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 09:30:17 -0000 Hello Mark, Mark Wielaard a =C3=A9crit: Thank you for looking into this! [...] > From d7253e475b6d04445d62ae5b55c03facbd6ab87d Mon Sep 17 00:00:00 2001 > From: Mark Wielaard > Date: Tue, 27 Oct 2020 14:06:03 +0100 > Subject: [PATCH] Assume subrange bounds types are unsigned if no underlyi= ng > type is given. > > When running abidiff on test34-libjemalloc.so.2-intel-16.0.3 it would > crash in array_type_def::subrange_type::get_length on the ABG_ASSERT > get_upper_bound() >=3D get_lower_bound(). This was because that file > contained a subrange upper_bound value encoded with data1 or data2 > without an underlying type. In that case we assumed the value was > encoded as a signed value which caused some of the upper bounds to > be negative (while the lower bound, which wasn't given, was assumed > to be zero). > > * src/abg-dwarf-reader.cc (build_subrange_type): Default > is_signed to false. > > Signed-off-by: Mark Wielaard Applied to master. Thanks! --=20 Dodji