From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by sourceware.org (Postfix) with ESMTPS id 0E8AB386F43F for ; Wed, 22 Apr 2020 09:46:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0E8AB386F43F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 2702840007; Wed, 22 Apr 2020 09:46:05 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 5E7F9581891; Wed, 22 Apr 2020 11:46:05 +0200 (CEST) From: Dodji Seketeli To: Matthias Maennich Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH v2 3/8] abg-elf-helpers: move some versioning helpers from abg-dwarf-reader Organization: Me, myself and I References: <20200420110846.218792-1-maennich@google.com> <20200421063551.222511-1-maennich@google.com> <20200421063551.222511-4-maennich@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Wed, 22 Apr 2020 11:46:05 +0200 In-Reply-To: <20200421063551.222511-4-maennich@google.com> (Matthias Maennich's message of "Tue, 21 Apr 2020 08:35:46 +0200") Message-ID: <874ktbetuq.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 09:46:10 -0000 Matthias Maennich a =C3=A9crit: > Move some definitions from abg-dwarf-reader to abg-elf-helpers that are > strictly only related to ELF. > > * abg-dwarf-reader.cc(get_symbol_versionning_sections): Move func= tion out. > (get_version_definition_for_versym): Likewise. > (get_version_needed_for_versym): Likewise. > (get_version_for_symbol): Likewise. > * abg-elf-helpers.cc(get_symbol_versionning_sections): Move funct= ion in. > (get_version_definition_for_versym): Likewise. > (get_version_needed_for_versym): Likewise. > (get_version_for_symbol): Likewise. > * abg-elf-helpers.cc(get_symbol_versionning_sections): Add declar= ation. > (get_version_definition_for_versym): Likewise. > (get_version_needed_for_versym): Likewise. > (get_version_for_symbol): Likewise. Likewise, I am tabifying this and adding spaces between the file name and the changed interface name. Applying to master. Thanks! Cheers, --=20 Dodji