From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by sourceware.org (Postfix) with ESMTPS id 98A533858C54 for ; Wed, 7 Jun 2023 14:46:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98A533858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org X-GND-Sasl: dodji@seketeli.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1686149186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1NVdY8EhelH0ohfmeH+v0/eo1O+MTtw1SjBHV6gznyI=; b=chQQ1z6Vne76ccgAK1e6F9lErhm15R4GfQb+hbvmhphdg8rChe7Hk61By+LU/e1VvkFGpl aEIphewSb4Yf2XVU+Le3qwG5nwRJ37YKNr+Omg9MGD1M0DBFm75W1B9brWFFYRH/JUxq0p ZKnys1Jgls2QNzlzoSsAav+Nuy4il9PUOEERRZ95hsF5U+b/U9GAgs0GJ5HuQImq8nT31k DB2LO/KeuxSxgc02W3Ap0RvhGzGBm2v/DwiMMbk/7viuveoGgbXQlc2+xh4CvroKgQ7rzz OoB71a3gxRB/rRbFCJ5UwONOeDQ9hg3OnH9OKIP+2rWmLQuv8Cc97rZHmI1bYw== X-GND-Sasl: dodji@seketeli.org X-GND-Sasl: dodji@seketeli.org X-GND-Sasl: dodji@seketeli.org Received: by mail.gandi.net (Postfix) with ESMTPSA id D3B031C000A; Wed, 7 Jun 2023 14:46:24 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 2CADCB4FD2; Wed, 7 Jun 2023 16:46:24 +0200 (CEST) From: Dodji Seketeli To: =?utf-8?Q?Matthias_M=C3=A4nnich?= Cc: libabigail@sourceware.org, gprocida@google.com, kernel-team@android.com Subject: Re: [PATCH 2/2] symtab reader: fix symtab iterator to support C++20 Organization: Me, myself and I References: <20230606085132.1894137-3-maennich@google.com> <20230606085132.1894137-4-maennich@google.com> X-Operating-System: CentOS Stream release 9 X-URL: http://www.seketeli.net/~dodji Date: Wed, 07 Jun 2023 16:46:24 +0200 In-Reply-To: <20230606085132.1894137-4-maennich@google.com> ("Matthias =?utf-8?Q?M=C3=A4nnich=22's?= message of "Tue, 6 Jun 2023 09:51:34 +0100") Message-ID: <875y7zfhz3.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: "Matthias M=C3=A4nnich" a =C3=A9crit: > From: Matthias Maennich > > Inheriting from std::vector::iterator causes the type to advertise > itself as a contiguous iterator. This causes a compilation error in > newer versions of libc++ that try to use contiguous-iterator-specific > optimizations in those situations. Fixed thus by explicitly specifying > the interator_concept tag. > > * abg-symtab-reader.h (symtab_iterator): Specify > iterator_concept as forward_iterator to support C++20 compilation. > > Signed-off-by: Matthias Maennich Applied to master, thanks! [...] Cheers, --=20 Dodji