From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by sourceware.org (Postfix) with ESMTPS id 8986A395253F for ; Thu, 17 Nov 2022 10:10:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8986A395253F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 2DE5D1C0017; Thu, 17 Nov 2022 10:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1668679825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q9v+JlOAKYi6EchkngSFEKhCQOD1+WQ2dlboCvRb+ig=; b=nnCbsUBPLVq2UKlBHZDMy4WW4dLGe8TH462Z4KYYdI3dJbnPJCrZqG+KdTq1OUD9ciMg/M J22IpXD/AG8TFYL+feSprPBYcGg/q/0Xt5zwGHiL0RN1xPtUJwyMwGJ/r2V3fPOKmbGZ74 qGFhMsC791+sxwvGQveqrtCw5d16XWFqTvAEHKNwdHq74tWhoxFiBg89FzBBRXWB/sU11C svApXxwIEz27xZs59Wkyp6uJrVR4k6GlkiRgNj2/MA2WMvnOnvDo/XqIv5wymiIKoLc06k d9e76YDkH7/szEg1QwlhgkIscbrM9+5V46yUyZnZ68zQ8S7Wr0QHkTkebcyS9g== Received: by localhost (Postfix, from userid 1000) id 459861800CDA; Thu, 17 Nov 2022 11:10:23 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com, sidnayyar@google.com, vvvvvv@google.com Subject: Re: [PATCH v2] Narrow Linux symbol CRCs to 32 bits Organization: Me, myself and I References: <20221027140928.1480353-1-gprocida@google.com> <20221111132151.798754-1-gprocida@google.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.9 X-URL: http://www.seketeli.net/~dodji Date: Thu, 17 Nov 2022 11:10:23 +0100 In-Reply-To: <20221111132151.798754-1-gprocida@google.com> (Giuliano Procida's message of "Fri, 11 Nov 2022 13:21:51 +0000") Message-ID: <875yfdq4c0.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Giuliano, Giuliano Procida a =C3=A9crit: > MODVERSIONS CRCs are 32-bit hashes of strings representing C type > elements or typed symbols. The hashes are calculated using a 32-bit > CRC, hence the name. The kernel module loading code (implicitly) > truncates any provided CRC value to 32 bits before comparing it with > anything. > > When support was added to libabigail, values up to 64 bits wide were > supported. This change narrows libabigail's concept of Linux CRC to 32 > bits. No tests are affected. > > * include/abg-ir.h (elf_symbol::elf_symbol): Change CRC type > from optional to optional. > (elf_symbol::create): Likewise. > (elf_symbol::get_crc): Likewise. > (elf_symbol::set_crc): Likewise. > * src/abg-ir.cc (elf_symbol::priv) Change CRC type from > optional to optional. > (elf_symbol::priv::priv): Likewise. > (elf_symbol::elf_symbol): Likewise. > (elf_symbol::create): Likewise. > (elf_symbol::get_crc): Likewise. > (elf_symbol::set_crc): Likewise. > * src/abg-reporter-priv.cc (maybe_report_diff_for_symbol): > Change CRC type from optional to > optional. > * src/abg-symtab-reader.cc (symtab::load_): Change crc_values > value type from uint64_t to uint32_t. Applied to master, thanks! [...] Cheers, --=20 Dodji