From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199])
	by sourceware.org (Postfix) with ESMTPS id D0C0938582A7
	for <libabigail@sourceware.org>; Tue, 20 Sep 2022 08:22:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D0C0938582A7
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
	by mail.gandi.net (Postfix) with ESMTPSA id 6177CFF814;
	Tue, 20 Sep 2022 08:22:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org;
	s=gm1; t=1663662168;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mtWb05NhYXF4L518e5/KPsMA3NwIfhda1ZthcBDyb2g=;
	b=hzyz03aJGn94/bAMcvi/HQHmovNE5SRYZ/HBP714dptvysOqwYIT61jvSQyXXIDrDpKZu5
	RDdGgVChVwXwX8NdQcZjlzUcvTILaUnZUXXF/LmfarrQ5F3pHcncTX6sJnga8rgnLnFnB1
	RL+wbknokAj75lcLkgEDxCn99clB9YLC1lESxrIYWIIMOUJg3St8CRUkSo0c7CT9C2fPBs
	xkf9fN1RfB+FphD2HCaEt8e3d+9TPJ3fVka/jmIbajRM0YLNlp1JQDYc5fswKZClWwz4Qk
	6+pbjaz87+rKF9MRh/FXxyxtt2L3pEWRmdJEtOJPXhJbu0PRBsBxsDbKbQTWdA==
Received: by localhost (Postfix, from userid 1000)
	id A583C5802BD; Tue, 20 Sep 2022 10:22:46 +0200 (CEST)
From: Dodji Seketeli <dodji@seketeli.org>
To: Xiaole He via Libabigail <libabigail@sourceware.org>
Cc: Xiaole He <hexiaole1994@126.com>,  Xiaole He <hexiaole@kylinos.cn>
Subject: Re: [PATCH] abg-reader: fix comment of function
Organization: Me, myself and I
References: <20220919100350.9661-1-hexiaole1994@126.com>
X-Operating-System: Fedora 38
X-URL: http://www.seketeli.net/~dodji
Date: Tue, 20 Sep 2022 10:22:46 +0200
In-Reply-To: <20220919100350.9661-1-hexiaole1994@126.com> (Xiaole He via
	Libabigail's message of "Mon, 19 Sep 2022 18:03:50 +0800")
Message-ID: <875yhi78vd.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libabigail.sourceware.org>

Hello,

Xiaole He via Libabigail <libabigail@sourceware.org> a =C3=A9crit:

> In 'src/abg-reader.cc', the function
> 'walk_xml_node_to_map_type_ids(read_context& ctxt, xmlNodePtr node)'
> find all of the child nodes of 'node' that has the 'id' attribute,
> and then put the child node into map where the 'id' of the child node
> as key and the child node itself as the value.
> But the comment for this function writes:
> /* src/abg-reader.cc begin */
> /// Walk an entire XML sub-tree to build a map where the key is the
> /// the value of the 'id' attribute (for type definitions) and the key
> /// is the xml node containing the 'id' attribute.
> ...
> static void
> walk_xml_node_to_map_type_ids(read_context& ctxt,
>                               xmlNodePtr node)
> ...
> /* src/abg-reader.cc end */
> The second and third lines of the comment above says the the child node
> as the key of the map, but it should be the value of the map.
> This patch fix the problematic comment described above, from
> 'and the key is the xml node' to 'and the value is the xml node'.
>
>         * src/abg-reader.cc (walk_xml_node_to_map_type_ids): fix comment

Thanks for catching that typo!  You are spot on!

I've applied the patch to the master branch.

[...]

Cheers,

--=20
		Dodji