From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by sourceware.org (Postfix) with ESMTPS id 34C783814FE8 for ; Tue, 7 Jun 2022 13:43:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 34C783814FE8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 633F1240004; Tue, 7 Jun 2022 13:43:50 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 766A65800FC; Tue, 7 Jun 2022 15:43:49 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH] XML writer: unify type emission tracking Organization: Me, myself and I References: <20220603130910.3039296-1-gprocida@google.com> X-Operating-System: Fedora 37 X-URL: http://www.seketeli.net/~dodji Date: Tue, 07 Jun 2022 15:43:49 +0200 In-Reply-To: <20220603130910.3039296-1-gprocida@google.com> (Giuliano Procida's message of "Fri, 3 Jun 2022 14:09:10 +0100") Message-ID: <875ylcmvvu.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 13:43:53 -0000 Giuliano Procida a =C3=A9crit: > Empirically, the tracking of declaration-only type emission no longer > seems to make any difference. It is removed here. > > * src/abg-writer.cc (write_context): Remove the > m_emitted_decl_only_set member. > (write_context::has_non_emitted_referenced_types): Remove the > calls to decl_only_type_is_emitted. > (write_context::record_decl_only_type_as_emitted): Removed. > (write_context::decl_only_type_is_emitted): Ditto. > (write_context::get_emitted_decl_only_types_set): Ditto. > (referenced_type_should_be_emitted): Remove the calls to > decl_only_type_is_emitted. > (write_class_decl): Just call record_type_as_emitted. > (write_union_decl): Ditto. > (write_enum_type_decl): Not changed, but now all 3 functions > have the same behaviour. > (write_canonical_type_ids): Remove the call to > get_emitted_decl_only_types_set. > > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji