From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net
 [217.70.183.197])
 by sourceware.org (Postfix) with ESMTPS id 81A933858C2C
 for <libabigail@sourceware.org>; Thu, 18 Nov 2021 08:49:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 81A933858C2C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
 by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id CDD111C0009;
 Thu, 18 Nov 2021 08:49:51 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 28F85581C23; Thu, 18 Nov 2021 09:49:51 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: "Jose E. Marchesi via Libabigail" <libabigail@sourceware.org>
Subject: Re: [PATCH] ctf: ctf_reader::read_corpus now sets a status
Organization: Me, myself and I
References: <20211116174307.23579-1-jose.marchesi@oracle.com>
X-Operating-System: Fedora 36
X-URL: http://www.seketeli.net/~dodji
Date: Thu, 18 Nov 2021 09:49:50 +0100
In-Reply-To: <20211116174307.23579-1-jose.marchesi@oracle.com> (Jose
 E. Marchesi via Libabigail's message of "Tue, 16 Nov 2021 18:43:07
 +0100")
Message-ID: <875ysp6e6p.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Nov 2021 08:49:55 -0000

Hello,

[...]

"Jose E. Marchesi via Libabigail" <libabigail@sourceware.org> a =C3=A9crit:


> diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc
> index 27eddc2e..9cfa6cb7 100644
> --- a/src/abg-ctf-reader.cc
> +++ b/src/abg-ctf-reader.cc
> @@ -1073,19 +1073,28 @@ create_read_context(std::string elf_path, ir::env=
ironment *env)
>  /// @return a shared pointer to the read corpus.
>=20=20
>  corpus_sptr
> -read_corpus(read_context *ctxt)
> +read_corpus(read_context *ctxt, elf_reader::status &status)
>  {

I have just added a comment to this function.

[...]

>
> 	* include/abg-ctf-reader.h: Include abg-elf-reader-common.h.
> 	read_corpus now gets an extra argument `status'.
> 	* src/abg-ctf-reader.cc (read_corpus): Likewise, and set `status'
> 	accordingly when the debug info is not found.
> 	* tools/abilint.cc (main): Pass a status argument to
> 	ctf_reader::read_corpus.
> 	* tools/abidiff.cc (main): Likewise.
>
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>

Applied to master.

Thanks!

Cheers,

--=20
		Dodji