From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by sourceware.org (Postfix) with ESMTPS id E310B3857807 for ; Mon, 8 Mar 2021 12:34:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E310B3857807 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 88.120.130.27 Received: from localhost (unknown [88.120.130.27]) (Authenticated sender: dodji@seketeli.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 3074124000A; Mon, 8 Mar 2021 12:34:21 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 75E3558000E; Mon, 8 Mar 2021 13:34:21 +0100 (CET) From: Dodji Seketeli To: Ben Woodard via Libabigail Subject: Re: [PATCH] Fix declaratons of conditionally defined functions Organization: Me, myself and I References: <20210302221112.30655-1-woodard@redhat.com> X-Operating-System: Fedora 34 X-URL: http://www.seketeli.net/~dodji Date: Mon, 08 Mar 2021 13:34:21 +0100 In-Reply-To: <20210302221112.30655-1-woodard@redhat.com> (Ben Woodard via Libabigail's message of "Tue, 2 Mar 2021 14:11:12 -0800") Message-ID: <875z21259u.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 12:34:26 -0000 Hello Ben, Ben Woodard via Libabigail a =C3=A9crit: > Functions relating to zip archives are declared but are never compiled > when --enable-zip-archive=3Dno, the default. > > This makes sure that they are not declared when they won't be defined > due to conditional compilation. > > Signed-off-by: Ben Woodard I have amended the commit log to add the ChangeLog part as explained in the document https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dblob;f=3DCOMMIT-LOG-GUID= ELINES. So here is what the adjusted commit log looks like: Functions relating to zip archives are declared but are never compiled when --enable-zip-archive=3Dno, the default. This makes sure that they are not declared when they won't be defined due to conditional compilation. * include/abg-reader.h (read_corpus_from_file): Guard the declaration of these overloads with #ifdef WITH_ZIP_ARCHIVE. * tools/abilint.cc: Guard the use of abigail::xml_reader::read_corpus_from_file with #ifdef WITH_ZIP_ARCHIVE. Other than that, the patch looks good to me and I have applied to master. Thanks! [...] Cheers, --=20 Dodji