From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH 3/3] abidiff: Omit declaration-only type size 0 diffs.
Date: Mon, 27 Apr 2020 13:15:40 +0200 [thread overview]
Message-ID: <875zdlb2n7.fsf@seketeli.org> (raw)
In-Reply-To: <20200422212059.258602-3-gprocida@google.com> (Giuliano Procida's message of "Wed, 22 Apr 2020 22:20:59 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
> When reporting declaration-only type changes, the size is reported as
> changing to or from 0, which is not correct. The declaration type is
> of unknown size. This patch eliminates such size reports.
>
> * src/abg-reporter-priv.cc (report_size_and_alignment_changes):
> Filter out declaration-only / defined type size changes
> unconditionally.
> * tests/data/test-abidiff-exit/test-decl-struct-report.txt:
> Update test.
Applied to master, thanks!
Cheers,
--
Dodji
next prev parent reply other threads:[~2020-04-27 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 21:20 [PATCH 1/3] Add tests for declaration-only struct diffs Giuliano Procida
2020-04-22 21:20 ` [PATCH 2/3] abidiff: Blank line after declaration-only diff Giuliano Procida
2020-04-27 11:15 ` Dodji Seketeli
2020-04-22 21:20 ` [PATCH 3/3] abidiff: Omit declaration-only type size 0 diffs Giuliano Procida
2020-04-27 11:15 ` Dodji Seketeli [this message]
2020-04-27 11:15 ` [PATCH 1/3] Add tests for declaration-only struct diffs Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zdlb2n7.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).