From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by sourceware.org (Postfix) with ESMTPS id DACBC38708AF for ; Mon, 27 Apr 2020 11:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DACBC38708AF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id AFAD140003; Mon, 27 Apr 2020 11:15:41 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 02FA8581891; Mon, 27 Apr 2020 13:15:40 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 3/3] abidiff: Omit declaration-only type size 0 diffs. Organization: Me, myself and I References: <20200422212059.258602-1-gprocida@google.com> <20200422212059.258602-3-gprocida@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Mon, 27 Apr 2020 13:15:40 +0200 In-Reply-To: <20200422212059.258602-3-gprocida@google.com> (Giuliano Procida's message of "Wed, 22 Apr 2020 22:20:59 +0100") Message-ID: <875zdlb2n7.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2020 11:15:43 -0000 Giuliano Procida a =C3=A9crit: > When reporting declaration-only type changes, the size is reported as > changing to or from 0, which is not correct. The declaration type is > of unknown size. This patch eliminates such size reports. > > * src/abg-reporter-priv.cc (report_size_and_alignment_changes): > Filter out declaration-only / defined type size changes > unconditionally. > * tests/data/test-abidiff-exit/test-decl-struct-report.txt: > Update test. Applied to master, thanks! Cheers, --=20 Dodji