From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by sourceware.org (Postfix) with ESMTPS id BA99C3858D28 for ; Tue, 31 Jan 2023 10:09:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA99C3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id B2433240016; Tue, 31 Jan 2023 10:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1675159796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ttAYUber0VlPg+fGxjoC4Z1QjCs8SDYW3lxrDmhN8ds=; b=HfMBB4zSKYLxERfJHjULXi7SZxQwcR3V0sKDw0832o5aOhD6+kE2UWpS7leS3Jxjb5Xlls GmiJxYeLv9++93Fi6u9F6vJPJd+RhDTj/uPS5aIM/yMav4ncm9plkXkes7LULb6XqVmVam Tkgsx32IymrOlQLQEeygYM9MPPfqoOyDLg02THCxtvq/MbNpeAh+1IPUuCapgs1YLxm+ZT e1t79pOKpyfi4fAl8o1vr5DK74QtNz7nsWls7gDgUTZn6NS5WER6xQLVt7qdsV3S5nsROm 3KC4Ima0aK4GNPzR2lnB3PHpOumUgFuawueLrf4Zpt6L92xa2ICLWshhCQZUjw== Received: by localhost (Postfix, from userid 1000) id CFD8AC1B9AFA; Tue, 31 Jan 2023 11:09:54 +0100 (CET) From: Dodji Seketeli To: Aleksei Vetrov via Libabigail Cc: vvvvvv@google.com, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH] symtab: fix getting CRC in relocatable modules Organization: Me, myself and I References: <20230128000818.1605970-1-vvvvvv@google.com> X-Operating-System: AlmaLinux 9.1 X-URL: http://www.seketeli.net/~dodji Date: Tue, 31 Jan 2023 11:09:54 +0100 In-Reply-To: <20230128000818.1605970-1-vvvvvv@google.com> (Aleksei Vetrov via Libabigail's message of "Sat, 28 Jan 2023 00:08:18 +0000") Message-ID: <877cx39frh.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Aleksei, Aleksei Vetrov via Libabigail a =C3=A9crit: > From: Aleksei Vetrov > > In ELF with ET_REL type symbol value holds not absolute but relative to > section value. This patch applies adjustment to the address, used in CRC > value extraction. > > * src/abg-elf-helpers.cc (get_crc_for_symbol): Rename > crc_symbol_value to crc_symbol_address and adjust it for > relocatable ELF types. > > Signed-off-by: Aleksei Vetrov Applied to mainline, thanks! [...] Cheers, --=20 Dodji