From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net
 [IPv6:2001:4b98:dc4:8::224])
 by sourceware.org (Postfix) with ESMTPS id 7E9A73858D28
 for <libabigail@sourceware.org>; Tue, 18 Jan 2022 16:13:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E9A73858D28
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
 by mail.gandi.net (Postfix) with ESMTPSA id 84E60E0009;
 Tue, 18 Jan 2022 16:13:31 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 22C30581891; Tue, 18 Jan 2022 17:13:30 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org,  kernel-team@android.com,  maennich@google.com
Subject: Re: [PATCH] abidiff: include ABI XML versions when reporting a
 mismatch
Organization: Me, myself and I
References: <20220118090315.854147-1-gprocida@google.com>
X-Operating-System: Fedora 36
X-URL: http://www.seketeli.net/~dodji
Date: Tue, 18 Jan 2022 17:13:30 +0100
In-Reply-To: <20220118090315.854147-1-gprocida@google.com> (Giuliano Procida's
 message of "Tue, 18 Jan 2022 09:03:15 +0000")
Message-ID: <877daxc991.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2022 16:13:34 -0000

Giuliano Procida <gprocida@google.com> a =C3=A9crit:

> In the rare event of an XML version mismatch it would be helpful to
> have the versions in the error message, particularly if abidiff is
> being run from automation.
>
> 	* tools/abidiff.cc
> 	(emit_incompatible_format_version_error_message): Add version1
> 	and version2 arguments. Add versions to error message.
> 	(main): Pass emit_incompatible_format_version_error_message
> 	mismatching versions.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>

Applied to master branch, thanks!

[...]

Cheers,

--=20
		Dodji