From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by sourceware.org (Postfix) with ESMTPS id 155FE385BF83 for ; Tue, 7 Apr 2020 13:56:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 155FE385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BCEAB1C0010; Tue, 7 Apr 2020 13:56:00 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id F100D581890; Tue, 7 Apr 2020 15:55:59 +0200 (CEST) From: Dodji Seketeli To: Matthias Maennich Cc: Giuliano Procida , libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 2/2] abidiff: Fix anonymous member size change reports. Organization: Me, myself and I References: <20200403215356.186742-1-gprocida@google.com> <20200403215356.186742-2-gprocida@google.com> <20200406160831.GB189388@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Tue, 07 Apr 2020 15:55:59 +0200 In-Reply-To: <20200406160831.GB189388@google.com> (Matthias Maennich's message of "Mon, 6 Apr 2020 18:08:31 +0200") Message-ID: <877dyrpfgw.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 13:56:03 -0000 Matthias Maennich a =C3=A9crit: [...] > > This broke one test case on my machine, that needs trivial adjusting: > > test-leaf-peeling-report-indirect.txt: > > | @@ -9,7 +9,6 @@ > | type 'int' of 'foo::z' changed: > | type name changed from 'int' to 'long int' > | type size changed from 32 to 64 (in bits) > | - and size changed from 32 to 64 (in bits) (by +32 bits) > | > | 'struct ops1 at test-leaf-peeling-v0.cc:5:1' changed: > | type size hasn't changed > | FAIL runtestabidiffexit (exit status: 1) Right. Also, I think you'll need to rebase this patch on top of current master as I have committed a patch from you that renames test-abidiff-exit/test-leaf1-report.txt. Thanks. Cheers, --=20 Dodji