From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by sourceware.org (Postfix) with ESMTPS id 94808385E822 for ; Fri, 13 Mar 2020 17:37:22 +0000 (GMT) X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1A79A1BF206; Fri, 13 Mar 2020 17:37:19 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 1CD63581890; Fri, 13 Mar 2020 18:37:19 +0100 (CET) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH 2/5] abg-leaf-reporter.cc: Fix indentation of function parameter diffs. Organization: Me, myself and I References: <20200312063036.29419-1-gprocida@google.com> <20200312063036.29419-3-gprocida@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Fri, 13 Mar 2020 18:37:19 +0100 In-Reply-To: <20200312063036.29419-3-gprocida@google.com> (Giuliano Procida's message of "Thu, 12 Mar 2020 06:30:33 +0000") Message-ID: <877dzow3zk.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2020 17:37:23 -0000 Hello Giuliano, Giuliano Procida a =C3=A9crit: > When reporting the details of changes to function parameter > differences in leaf-changes-only mode, the details are output at the > same level of indentation as the introductory text. In default mode > the usual 2-space indentation is used. > > This patch fixes this discrepancy, making the output more readable. > > * src/abg-leaf-reporter.cc (report): In the fn_parm_diff > override, indent the lines of detail by 2 spaces. > * tests/data/test-abidiff-exit/test-leaf3-report.txt: Update > report with correct indentation. This looks good to me and has been applied to master. Cheers, --=20 Dodji